fix(ui): typography polish — 27px hero, Mono-Only-Uppercase, mono-weight no-ops, verbatim table heads (0.8.4)#138
Conversation
|
Warning Review limit reached
More reviews will be available in 54 minutes and 8 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughVersion 0.8.4 corrects typography token overrides across multiple UI surfaces: normalizes mono label weights from 600 to 500, switches ChangesTypography Token Normalization v0.8.4
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ght no-ops, verbatim table heads (0.8.4) /impeccable critique (fonts & font-sizes) → polish. Resolves the peripheral type-discipline drifts the source review found: - .metric-card__value: drop a token-migration 30px override so the documented 27px hero-number (DESIGN.md §3) ships. - Mono-Only-Uppercase: .wiki-info-grid dt, .wiki-preview__header, and MB-Web .mb-lab move from sans-uppercase eyebrows to the mono label voice (0.04em). - font-synthesis honesty: .bi-colhead span / .import-step__marker / .trace-invocation__dur drop a mono font-weight:600 no-op (mono ships 400/500 → already rendered 500) to declare 500. - Content fidelity: .markdown-table-wrap th renders user header rows verbatim (removed force-uppercase); DESIGN.md §3 clarifies "table heads" = workbench data-table labels, not user markdown headers. - .wisdom-dialog__header h2 tokenized to the title role (sans 600); .markdown-chart__caption onto the role ladder (body-sm). New e2e guards inject the auth/hover/MB/state-gated surfaces the passive invariant sweeps can't render, so the type rules are guarded there too. The injection cases use an `id` prop (not `key`) so gitleaks's generic-api-key rule doesn't read `key: "<camelCase>"` as a secret. verify gate green (57 e2e passed); independent review: ship. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fourth
/impeccable critique→ polish round (after 0.8.1/0.8.2/0.8.3), scoped to fonts & font sizes across all routes. The two isolated assessments (source design review + detector/browser computed-style sweep) found the type system is genuinely strong (serif honesty, closed 6-role px ladder, 11px floor) — the remaining drift is peripheral edge-discipline on auth/hover/MB/state-gated surfaces the passive invariant sweeps never render. Score 32/40.Fixed (all
src/styles.css/src/mb/mb.css).metric-card__valueto 30px over the 27px base rule; DESIGN.md §3 documents the hero-number as 27px twice. Dropped the override..wiki-info-grid dt(siblings already mono),.wiki-preview__header, and MB-Web.mb-lab(the twin of the mono.bi-colhead span) moved from sans-uppercase "eyebrows" to the mono label voice at 0.04em.font-weight: 600no-ops → 500. IBM Plex Mono ships only 400/500, so600rendered as 500 anyway:.bi-colhead span,.import-step__marker,.trace-invocation__durnow declare 500 (zero visual change, honest CSS)..markdown-table-wrap thno longer force-uppercases the author's header row (content-fidelity breach —pH/mRNAwas mangled — and a sans-eyebrow tell). Distinct by weight + surface, not case. DESIGN.md §3 now distinguishes "table heads" (workbench data-table labels, mono) from user markdown headers (verbatim)..wisdom-dialog__header h2tokenized to the title role (was untokenized 17px inheriting UA bold 700; now sans 600, parity with.wisdom-card h2)..markdown-chart__caption0.85em→body-smtoken (on the role ladder).Tests
New
typography.spec.tsguards — "type-system rules hold on sweep-unreachable surfaces (workbench)" + "MB-Web column labels use the mono uppercase voice" — inject the minimal DOM for each gated selector so the stylesheet's own rule is asserted directly (auth/data-independent). Genuine RED→GREEN on every fix.Verification
npm run verifygreen — lint + format:check + typecheck + coverage + build + e2e (57 passed, no flake).document.fontsconfirms IBM Plex Mono 400/500 load (no fallback) and no 600 face exists..wiki-preview__headerwraps an i18n chrome label not user content).🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Tests