[DRAFT] Add build option to build for can classic#19
Open
schnili wants to merge 1 commit into
Open
Conversation
schnili
changed the title
Member
|
This is cool, but can we please make it runtime-selectable? This is useful because sometimes a CAN FD capable node has to operate on a Classic CAN network. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the examples!
I stumbled over the note 'Note that this will only work over CAN FD. If you need to run PnP over Classic CAN, use message v1.0.' and implemented the necessary changes as a build option.