fix: launch Hermes safely on Windows#3704
Merged
Merged
Conversation
CompleteDotTech
marked this pull request as ready for review
July 23, 2026 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows now uses the native Hermes executable with prompt flags instead of the POSIX-only hermes-coven shim.
Adapter scaffolding and legacy-manifest repair now consistently honor the active
COVEN_HOMEacross configuration changes, Familiar creation, onboarding, regular Chat, and Board task launches. This keeps customized Node, Windows, macOS, and Linux installations on the active Coven state rather than silently writing to a different default home.Legacy Cave-generated Hermes manifests are repaired before Board and regular Chat launches. User-authored manifests are left untouched.
Root cause
The synced Hermes registry recipe expected the POSIX shim while Windows installs hermes.exe only. Retrying a work card therefore failed before Hermes could start.
Compatibility objective
Coven Cave is intentionally broad about both installation and runtime shape: Node/package-managed, native Windows, macOS, and Linux installations, along with harnesses such as Codex, OpenClaw, Hermes, and future adapters. This PR therefore limits its repair to Cave-owned, known-legacy Hermes manifests on Windows. It preserves user-authored manifests and existing non-Hermes adapters rather than assuming one executable, package manager, platform, or harness layout fits every installation.
Cross-repository compatibility
This preserves the POSIX shim recipe on macOS/Linux and scopes the Windows native argv recipe to Hermes only; it does not replace user-authored adapter manifests or alter other harnesses (including Codex and OpenClaw).
Depends on OpenCoven/coven#465. That CLI change makes the trusted Hermes recipe platform-aware, so Cave's Windows manifest is accepted by the daemon while the exact POSIX recipe remains trusted on macOS/Linux. Keep this PR draft until that CLI release is available.
Validation
tsc --noEmitnode scripts/run-tests.mjs api(239 API test files)