Fully update chemicaljson.py to Python >= 3.10 and Pydantic >= 2, with Numpy-style docstrings#35
Open
brockdyer03 wants to merge 1 commit into
Open
Conversation
Signed-off-by: brockdyer03 <brockdyer03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit more extensive of a rework than that in #34, since it automatically implies Python >= 3.10 in addition to Pydantic >= 2.
Some notable features are the addition of more comprehensive docstrings that follow the Numpy docstring standard and removing the outdated syntax for type hints such as
OptionalandList.I also took the liberty of aligning the type hints and
Fielddeclarations to make the source code a bit more readable (in my opinion).