DRAFT: [jaxrs-spec][quarkus] Emit @Authenticated for HTTP Basic, Bearer, api-key and OAuth2 or OpenID with empty scopes array#23680
Draft
Ignacio-Vidal wants to merge 6 commits intoOpenAPITools:masterfrom
Conversation
2eb7ff4 to
471d62a
Compare
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaJAXRSSpecServerCodegen.java # modules/openapi-generator/src/main/resources/JavaJaxRS/spec/libraries/quarkus/apiInterface.mustache # modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jaxrs/JavaJAXRSSpecServerCodegenTest.java
7479247 to
5daad84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[[ Dependent on #23699 to hide the annotation generation behind the cli flag ]]
This is part of #23691 to improve the support for Authentication and Authorisation in the jaxrx-spec/quarkus server generator.
It emits
@io.quarkus.security.Authenticatedon JAX-RS interface methods and implementation stubs when an operation security has either:PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Emit
@io.quarkus.security.Authenticatedon Quarkus JAX-RS endpoints that require auth without scopes, so generated APIs enforce authentication but not role scopes. Covers OAuth2/OpenID with empty scopes,basic,bearer, andapiKey, with correct handling of multi-flow and OR cases and no duplicate annotations.x-quarkus-authenticatedinJavaJAXRSSpecServerCodegen(Quarkus only) and render@io.quarkus.security.AuthenticatedinapiInterface.mustacheandapiMethod.mustache.basic,bearer, andapiKey; new fixtures includequarkus-oauth2-*,quarkus-openidconnect-*,quarkus-http-*, andquarkus-api-key.yaml. Regenerated Quarkus samples to include the annotation where applicable.Written for commit 5daad84. Summary will update on new commits.