Skip to content

Last Timing Label - #2

Draft
ssnak wants to merge 16 commits into
Oondanomala:masterfrom
ssnak:dev
Draft

Last Timing Label#2
ssnak wants to merge 16 commits into
Oondanomala:masterfrom
ssnak:dev

Conversation

@ssnak

@ssnak ssnak commented Mar 28, 2025

Copy link
Copy Markdown

no comment

ssnak added 13 commits March 23, 2025 22:21
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
Signed-off-by: ssnak <sergregarias@gmail.com>
…the 1 dimensional direction vector

Signed-off-by: ssnak <sergregarias@gmail.com>
@Oondanomala

Copy link
Copy Markdown
Owner

I know its too early for a review, but two things:

  • you should use an enum for the different timings instead of using strings
  • merge the Input class with PlayerState, there's no point in having two which do very similar things (and that's what PlayerState was meant to do anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants