Skip to content

Fix citation navigation to parsed chunk list - #98

Merged
suguanYang merged 1 commit into
mainfrom
fix/citation-list-view-targets
Jun 15, 2026
Merged

Fix citation navigation to parsed chunk list#98
suguanYang merged 1 commit into
mainfrom
fix/citation-list-view-targets

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • Route citation-driven source navigation through an explicit parsed-list request so source-only or unresolved citations do not leave the chunks panel in tree mode.
  • Preserve the existing tree default for normal source selection.
  • Add regression coverage for product-manual-style source/image citations.

Verification

  • ./node_modules/.bin/vitest run src/components/chunks-panel.test.ts src/components/workspace-citation-focus.test.ts src/components/workspace-shell.test.ts src/components/workspace-shell-layout.test.ts src/components/chat-message-list.test.ts src/components/chat-panel.test.ts
  • ./node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/eslint
  • ./node_modules/.bin/next build
  • git diff --check origin/main..HEAD

Notes: tsc still prints the existing Effect JSON advisory in src/integrations/knowhere-demo.ts. eslint still prints the existing unused Source warning in src/domains/sources/route-upload.ts. next build still warns that it patched missing SWC lockfile entries and inferred /home/suguan as the workspace root; generated package-lock churn was not kept.

@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jun 14, 2026 5:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Jun 14, 2026 5:09pm

Request Review

@suguanYang
suguanYang merged commit e2dc286 into main Jun 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant