feat(chat): strengthen notebook agent harness outputs - #97
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalize, tool-call tracing, context-policy-gated prior-turn reads, and validation fallback behavior.derived_tableartifacts that can be created from evidence refs, validated against the ledger, persisted, mapped to citations, and rendered in chat.Validation
pnpm vitest runpnpm run typecheckpnpm run lintLint passes with the existing warning in
src/domains/sources/route-upload.tsfor unusedSource.Real KNOWHERE Smoke
http://localhost:5005; this was used only for local smoke testing and was not written into Notebook code.defaultnamespace and returns evidence for existing documents.declareIntent -> setContextPolicy -> retrieve -> finalize; validation passed and produced aderived_tablebacked by real ledger refs.Deployment Note
process.env.KNOWHERE_BASE_URLonly as an optional override.https://api.knowhereto.ai.knowhere-api-infraconfirms AWS production API ingress isapi.knowhereto.aiand staging isapi-staging.knowhereto.ai.localhost,default, orchengke-kbas production constants.Current Scope Boundary
This improves the agent harness and source-backed outputs. Full chart/image analysis still needs follow-up tools such as image artifact analysis, chart data extraction, web read/search, spreadsheet generation, and calculation.