Skip to content

feat(chat): strengthen notebook agent harness outputs - #97

Merged
suguanYang merged 3 commits into
mainfrom
feat/wuchengke/notebook-agent-harness-release
Jun 15, 2026
Merged

feat(chat): strengthen notebook agent harness outputs#97
suguanYang merged 3 commits into
mainfrom
feat/wuchengke/notebook-agent-harness-release

Conversation

@EricNGOntos

@EricNGOntos EricNGOntos commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Strengthen the Notebook agent harness contract with required finalize, tool-call tracing, context-policy-gated prior-turn reads, and validation fallback behavior.
  • Add source-backed derived_table artifacts that can be created from evidence refs, validated against the ledger, persisted, mapped to citations, and rendered in chat.
  • Tighten citation/artifact selection so grounded answers prefer agent-selected refs and displayed artifacts instead of falling back to every retrieved result.
  • Remove the local Cursor plan artifact from the branch so the PR only carries product code and tests.

Validation

  • pnpm vitest run
  • pnpm run typecheck
  • pnpm run lint

Lint passes with the existing warning in src/domains/sources/route-upload.ts for unused Source.

Real KNOWHERE Smoke

  • Verified the local Typing store points to http://localhost:5005; this was used only for local smoke testing and was not written into Notebook code.
  • Confirmed real KNOWHERE retrieval works against local default namespace and returns evidence for existing documents.
  • Ran a real harness tool-flow smoke with declareIntent -> setContextPolicy -> retrieve -> finalize; validation passed and produced a derived_table backed by real ledger refs.

Deployment Note

  • Notebook still uses process.env.KNOWHERE_BASE_URL only as an optional override.
  • When unset, the SDK defaults to cloud production https://api.knowhereto.ai.
  • knowhere-api-infra confirms AWS production API ingress is api.knowhereto.ai and staging is api-staging.knowhereto.ai.
  • This PR does not introduce localhost, default, or chengke-kb as production constants.

Current Scope Boundary

This improves the agent harness and source-backed outputs. Full chart/image analysis still needs follow-up tools such as image artifact analysis, chart data extraction, web read/search, spreadsheet generation, and calculation.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jun 13, 2026 2:41am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Preview Jun 13, 2026 2:41am

Request Review

@EricNGOntos EricNGOntos changed the title feat(chat): add notebook agent harness artifacts feat(chat): strengthen notebook agent harness outputs Jun 13, 2026
@EricNGOntos
EricNGOntos requested a review from suguanYang June 13, 2026 02:44
@suguanYang
suguanYang merged commit 1dd94a1 into main Jun 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants