Skip to content

Fix chunk image rendering after full-tree loads - #122

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chunk-image-assets
Jun 30, 2026
Merged

Fix chunk image rendering after full-tree loads#122
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chunk-image-assets

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • keep visible paged chunk fetches active even when full-tree prefetched chunks exist
  • merge paged chunk asset URLs back into full-tree chunk data by chunk id
  • render standalone image uploads from the selected source original file when Knowhere omits a chunk asset URL

Why

The tree preload calls the structure-only chunks endpoint without asset URLs. Those prefetched chunks were taking precedence over the visible paged chunks, so image chunks lost their assetUrl and rendered the fallback label on staging.

Verification

  • pnpm vitest run src/components/workspace-selected-chunks.test.ts src/components/parsed-chunk-card.test.ts src/components/chunks-panel.test.ts
  • pnpm typecheck
  • pnpm lint
  • git diff --check origin/staging..HEAD

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jun 30, 2026 3:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Jun 30, 2026 3:00pm

Request Review

@suguanYang
suguanYang merged commit 4ecbed7 into staging Jun 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant