Support default namespace document compatibility - #117
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultwith safedocumentMetadatafor display/client origin.defaultand the legacy workspace namespace, then localizes those documents into regular Notebooksourcesrows before UI, chunks, archive, and chat flows use them.knowhere-doc:*remote source action path; chunk/archive routes now require a localized Notebook source row or a canonical demo source.workspace_id + knowhere_document_idfor live rows.knowhereJobIduntil the existing job workflow stores parse assets and marks the source ready.defaultplus the legacy workspace namespace and merges successful retrieval responses.documentIddirectly when job creation returns it.Companion backend PR: Ontos-AI/knowhere#177
Companion SDK PR: Ontos-AI/knowhere-node-sdk#99
Testing
./node_modules/.bin/vitest run src/domains/sources/route-service.test.ts src/domains/sources/source-row-repository.test.ts 'src/app/api/sources/[sourceId]/route.test.ts' 'src/app/api/sources/[sourceId]/chunks/route.test.ts' src/domains/workspace/initial-state.test.ts src/domains/chat/route-service.test.ts src/domains/chat/index.test.ts src/domains/sources/upload.test.ts src/integrations/knowhere.test.ts./node_modules/.bin/tsc --noEmit --pretty false./node_modules/.bin/eslint ...git diff --checkNotes:
effect-solutionsfor Effect changes, buteffect-solutionsis not installed on this machine (command not found), so this follows existing local Effect patterns.