Skip to content

Add explicit "Leave At" time to Trip Planner results #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronbrethorst merged 2 commits into from
Jan 23, 2026
Merged

Add explicit "Leave At" time to Trip Planner results #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcdb843
Add Leave at departure time to Trip Planner list
diveshpatil9104 Jan 22, 2026
e99585c
refactor: update labels to Depart/Arrive and set both time font weigh…
diveshpatil9104 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions OTPKit/Sources/OTPKit/Presentation/Sheets/TripPlanner/Components/ItineraryPreviewView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,20 @@ struct ItineraryPreviewView: View {
Text(Formatters.formatTimeDuration(itinerary.duration))
.font(.title)
.fontWeight(.semibold)

HStack(spacing: 2) {
Text("ETA:")
HStack(spacing: 4) {
Text(OTPLoc("trip_preview.depart_label"))
.foregroundStyle(.secondary)
Text(Formatters.formatDateToTime(itinerary.startTime))
.fontWeight(.medium)
Text("•")
.foregroundStyle(.secondary)
Text(OTPLoc("trip_preview.arrive_label"))
.foregroundStyle(.secondary)
Text(Formatters.formatDateToTime(itinerary.endTime))
.fontWeight(.medium)
.foregroundStyle(.secondary)
}
.font(.subheadline)

legsFlow(itinerary: itinerary)
.frame(
Expand Down
2 changes: 2 additions & 0 deletions OTPKit/Sources/OTPKit/Resources/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
/* Trip Preview */
"trip_preview.cancel_button" = "Cancel";
"trip_preview.start_button" = "Start";
"trip_preview.depart_label" = "Depart:";
"trip_preview.arrive_label" = "Arrive:";

/* Option Row */
"option_row.selected_hint" = "Selected";
Expand Down
2 changes: 2 additions & 0 deletions OTPKit/Sources/OTPKit/Resources/es.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
/* Trip Preview */
"trip_preview.cancel_button" = "Cancelar";
"trip_preview.start_button" = "Comenzar";
"trip_preview.depart_label" = "Salida:";
"trip_preview.arrive_label" = "Llegada:";

/* Option Row */
"option_row.selected_hint" = "Seleccionado";
Expand Down
2 changes: 2 additions & 0 deletions OTPKit/Sources/OTPKit/Resources/zh-Hans.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@
/* Trip Preview */
"trip_preview.cancel_button" = "取消";
"trip_preview.start_button" = "开始";
"trip_preview.depart_label" = "出发：";
"trip_preview.arrive_label" = "到达：";

/* Option Row */
"option_row.selected_hint" = "已选择";
Expand Down
Loading