Skip to content

chore: fix errcheck and staticcheck linting errors#1002

Merged
burma-shave merged 3 commits into
OneBusAway:mainfrom
3rabiii:fix-linting-erros
Jul 1, 2026
Merged

chore: fix errcheck and staticcheck linting errors#1002
burma-shave merged 3 commits into
OneBusAway:mainfrom
3rabiii:fix-linting-erros

Conversation

@3rabiii

@3rabiii 3rabiii commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Changes Included:

  • errcheck Fixes: Addressed unhandled errors from rows.Close() in gtfsdb/block_layover_test.go and gtfsdb/stops_rtree.go by wrapping them in anonymous defer functions.
  • staticcheck (QF1008) Fixes: Removed redundant embedded field selectors (e.g., calling .Time.Time or .ServiceDate.Time) in internal/models/current_time_test.go and internal/models/trip_details_test.go to utilize Go's promoted methods for cleaner syntax.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@3rabiii, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57135d35-6ee5-4572-9b60-44aec4488ba3

📥 Commits

Reviewing files that changed from the base of the PR and between 41be7c8 and 571b367.

📒 Files selected for processing (2)
  • internal/models/current_time_test.go
  • internal/models/trip_details_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@3rabiii 3rabiii requested a review from burma-shave June 4, 2026 11:04
Comment thread gtfsdb/stops_rtree.go Outdated
@sonarqubecloud

Copy link
Copy Markdown

@3rabiii 3rabiii requested a review from burma-shave June 30, 2026 23:54
@burma-shave burma-shave merged commit d7f5728 into OneBusAway:main Jul 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants