Conversation
v3.0.3 See merge request amrit/development/format-checker!22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating NVS tables R01, R03, R08, R18, R23, R24, R25, R26, R27, R40 and R41.
Table verification result:checks_NVS_results.csv. The last errors do not prevent to go on. As there is no usage of these entries, it is fine for now. However, they are tackled in dedicated AVTT tickets, and a solution is sought fr them.
Full compare between 3.0.3 and 3.0.4 for the latest month of updated files completed soon:
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_jma.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_meds.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_kiost.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_incois.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_csiro.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_csio.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_bodc.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_coriolis.csv
diff_file_checker_exec-3.0.3_vs_file_checker_exec-3.0.4_aoml.csv
synthesis:
The warning message when PROGRAM_NAME is "" has changed (due to a NVS choice for a non-used concept ID), but I think it is fine at this stage.
Argo eq. FRANCE is no more correct and shall be changed to Argo eq FRANCE.
CONGIF_GroundingModeDeepZoneThickness does not trigger a warning anymore.
Pelle ROBBINS is now accepted.
Evolution (RBR_ARGO3.1 and ARVOR2) were tested:
6903075_meta.nc and the result 6903075_meta.nc.filecheck
7902405_meta.nc and the result 7902405_meta.nc.filecheck