Add known hosts handling#1958
Merged
Merged
Conversation
# Conflicts: # source/Calamari.Tests/ArgoCD/Git/GitHttpSmartSubTransportTests.cs
# Conflicts: # source/Calamari.Tests/ArgoCD/Git/RepositoryWrapperTest.cs
# Conflicts: # source/Calamari.Contracts/ArgoCD/ArgoCDCustomPropertiesDto.cs # source/Calamari.Tests/ArgoCD/Contracts/ArgoCDCustomPropertiesDtoSerializationTests.cs # source/Calamari.Tests/ArgoCD/Git/AuthenticatingRepositoryFactoryTests.cs # source/Calamari/ArgoCD/Git/AuthenticatingRepositoryFactory.cs # source/Calamari/ArgoCD/Git/GitConnection.cs # source/Calamari/ArgoCD/Git/IGitCredentialDtoJsonConverter.cs # source/Calamari/ArgoCD/Git/PullRequests/GitVendorPullRequestClientResolver.cs # source/Calamari/ArgoCD/Git/PullRequests/StringExtensionMethods.cs # source/Calamari/ArgoCD/Git/RepositoryFactory.cs # source/Calamari/ArgoCD/Git/RepositoryWrapper.cs
# Conflicts: # source/Calamari.Contracts/ArgoCD/ArgoCDCustomPropertiesDto.cs # source/Calamari.Contracts/Git/GitCredentials.cs
# Conflicts: # source/Calamari.Tests/ArgoCD/Git/AuthenticatingRepositoryFactoryTests.cs # source/Calamari.Tests/ArgoCD/Git/RepositoryFactoryTests.cs # source/Calamari/ArgoCD/Git/AuthenticatingRepositoryFactory.cs # source/Calamari/ArgoCD/Git/GitConnection.cs # source/Calamari/ArgoCD/Git/LibGit2SharpCredentialsHandlerExtensionMethods.cs # source/Calamari/ArgoCD/Git/RepositoryFactory.cs # source/Calamari/ArgoCD/Git/RepositoryWrapper.cs # source/Calamari/CommitToGit/CommitToGitConfigFactory.cs
APErebus
approved these changes
May 26, 2026
Contributor
APErebus
left a comment
APErebus
left a comment
There was a problem hiding this comment.
LGTM! Just 1 query for my own knowledge
| string hostname, | ||
| byte[] presentedSha256) | ||
| { | ||
| var lookupHost = StripPort(hostname); |
Contributor
There was a problem hiding this comment.
Are we not given the port in the hostname to validate?
Contributor
Author
There was a problem hiding this comment.
Very good point, I was under the impression that we needed this - but your work on known hosts has disproven that.
I'll remove this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checking of known hosts when using git ssh authentication
Relates to MD-1831