Skip to content

Update Brainstorm to use new Immolate2 API#63

Open
OceanRamen wants to merge 5 commits into
Voucher-searchfrom
feature/legendary-list
Open

Update Brainstorm to use new Immolate2 API#63
OceanRamen wants to merge 5 commits into
Voucher-searchfrom
feature/legendary-list

Conversation

@OceanRamen

Copy link
Copy Markdown
Owner

Summary

  • Update ffi.cdef in Core/Brainstorm.lua to match the new brainstorm(seed, pack, tag, souls) signature (removed voucher, observatory, perkeo params)
  • Remove voucher/observatory/perkeo logic from autoReroll() and DEFAULT_CONFIG.ar_filters
  • Remove the VOUCHER SEARCH and LEGENDARY UI cycle controls from UI/ui.lua along with their callback functions and lookup tables
  • Replace Immolate.dll with the new build and update immolate/immolate.cpp

Notes for reviewer

The brainstorm_query() JSON filter path is unchanged - complex filtering (vouchers, legendaries, etc.) can still be expressed via .bff.lua filter files using the query DSL. The removed UI controls only affected the legacy simple-filter mode.

OceanRamen and others added 5 commits June 14, 2026 02:16
- Implemented main logic in main.cpp, including various filters for game mechanics.
- Created rng.cpp and rng.hpp to define item sources and random types.
- Developed search.cpp and search.hpp for handling search operations with multithreading support.
- Added seed.cpp and seed.hpp for seed management and conversion.
- Introduced util.cpp and util.hpp for utility functions, including random number generation and hashing.
- Established a benchmark system to evaluate performance across different filters and scenarios.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Implement main logic in main.cpp, including various filters for game mechanics.
- Introduce RNG functionality in rng.cpp and rng.hpp to handle random number generation.
- Create search functionality in search.cpp and search.hpp for efficient seed searching.
- Develop seed management in seed.cpp and seed.hpp to handle seed representation and manipulation.
- Add utility functions in util.cpp and util.hpp for mathematical operations and random number handling.
- Establish a benchmark system to evaluate performance across different filters and configurations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Immolate DLL was rebuilt with a simplified brainstorm() C API:
  old: brainstorm(seed, voucher, pack, tag, souls, observatory, perkeo)
  new: brainstorm(seed, pack, tag, souls)

Voucher, observatory, and perkeo parameters were removed from the
legacy simple filter path; complex filtering is handled via the
existing brainstorm_query() JSON filter system.

Changes:
- Update ffi.cdef to match new brainstorm() signature
- Remove voucher/observatory/perkeo logic from autoReroll()
- Drop voucher_name, voucher_id, inst_observatory, inst_perkeo,
  legendary_choice, legendary_id from DEFAULT_CONFIG.ar_filters
- Remove VOUCHER SEARCH and LEGENDARY UI cycle controls
- Remove now-dead callback functions and lookup tables from ui.lua
- Replace Immolate.dll with the new build
- Update immolate/immolate.cpp with the new implementation

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 15, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@KrishRVH

KrishRVH commented Jun 19, 2026

Copy link
Copy Markdown

Great to see activity on this amazing project! I have a pretty comprehensive rewrite fork I've been working on over the past few months that adds a tonne of features - feel free to take a look and use whatever you'd like (although it's in Rust.) Thanks a lot for making this awesome mod and continuing to work on it! You might find the BalatroSource_Guide.md to be especially useful to your agents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants