Skip to content

Fix CI lint failure in formula parser regex patterns - #18

Merged
Ocean82 merged 3 commits into
mainfrom
copilot/fix-with-copilot
Jul 26, 2026
Merged

Fix CI lint failure in formula parser regex patterns#18
Ocean82 merged 3 commits into
mainfrom
copilot/fix-with-copilot

Conversation

Copilot AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

The CI run failed in npm run lint due no-useless-escape violations in src/agent/formulaPatterns.ts. This PR applies a minimal parser-only fix to those regex literals.

  • Problem scope

    • The failing job reported three lint errors in advanced formula parsing patterns (COUNTIF, SUMIF, IF) caused by unnecessary escaping in regex groups.
  • Code changes

    • Updated three regex alternatives from (\s+to)? to (\\s+to)? inside template string regex sources.
    • Kept matching semantics unchanged while making the regex source valid for ESLint.
  • Example (representative change)

// before
(equals?(\s+to)?|is|=|>=|<=|>|< ...)

// after
(equals?(\\s+to)?|is|=|>=|<=|>|< ...)

Copilot AI changed the title [WIP] Fix issue with Copilot integration Fix CI lint failure in formula parser regex patterns Jul 26, 2026
Copilot AI requested a review from Ocean82 July 26, 2026 06:22
@Ocean82

Ocean82 commented Jul 26, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved. I merged origin/main into this branch and fixed the conflict in src/agent/formulaPatterns.ts in commit dca7de8.

Copilot AI requested a review from Ocean82 July 26, 2026 06:54
@Ocean82
Ocean82 marked this pull request as ready for review July 26, 2026 08:06
Copilot AI review requested due to automatic review settings July 26, 2026 08:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ocean82
Ocean82 merged commit 327e7ab into main Jul 26, 2026
1 of 2 checks passed
@Ocean82
Ocean82 deleted the copilot/fix-with-copilot branch July 26, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants