refactor: split parsers.test.ts into dedicated files (#317)#592
refactor: split parsers.test.ts into dedicated files (#317)#592goureeshreddy7 wants to merge 1 commit into
Conversation
|
Thanks @goureeshreddy7 for the contribution. I will take a look this week. |
|
Thanks for tackling this - the split structure looks clean and the test organization makes sense. A few things to sort before merge:
Rebase needed - the branch is behind main. After rebasing you'll need to handle a conflict: Once those three are resolved this is ready. |
f34b4bf to
dd201f3
Compare
|
Thanks for the review, @sonukapoor sir ! I completely agree about args.ts— I will now open a separate small PR for the "help" suggestion. I have reverted the accidental inclusions (package-lock.json and args.ts) and fully rebased the branch onto The branch is totally clean and ready to go now! Let me know if you need anything that i need do for this . |
Hey @sonukapoor! I wanted to help out with issue #317.
I went ahead and split the massive "parsers.test.ts" file into the 7 dedicated files you mentioned under a new "tests/parsers/" folder. I also deleted the old file to clean it up.
I ran "npm test" locally on my machine and all tests are passing perfectly without any issues. Let me know if everything looks good or if I need to change anything! Thank you !
Closes #317