Single python script2 - #181
Conversation
|
This is still not working right for me --> If this is intentional thats fine but I fear it is because the pythonpath is now linked to the osop root - it makes it so when you run any code it attempts to commit the changes. Straight run with no flags caused vs code git hub to suggest commiting 627 files. TLDR: |
There was a problem hiding this comment.
Pull request overview
This PR replaces the legacy top-level shell orchestration with a Python-based runner (scripts/run_all.py) driven by a single YAML configuration file (osop_config.yml), and updates documentation/tests accordingly.
Changes:
- Add a Python orchestrator (
scripts/run_all.py) that executes existing workflow steps via subprocesses using a YAML config. - Add comprehensive pytest coverage for config parsing/validation and pipeline command construction (
scripts/tests/test_run_all.py). - Remove legacy shell runners and an unused downloader script; update user documentation (
docs/source/run.md).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/test_run_all.py | New unit tests for the Python orchestrator (config validation + pipeline behavior via mocking). |
| scripts/run_all.sh | Removes the legacy bash top-level runner. |
| scripts/run_all.py | Adds the new Python top-level orchestrator replacing the shell runner. |
| scripts/output/single_script/logfiles/download_log_total_precipitation_meteo_france_5_2026-07-31_09:41:26.txt | Adds a captured runtime log output (likely unintended repo artifact). |
| scripts/get_any_hc_fc_iri.py | Removes a deprecated/unused downloader script. |
| scripts/all_mons_precip_array.sh | Removes legacy SLURM/bash array runner. |
| scripts/all_mons_array.sh | Removes legacy SLURM/bash array runner. |
| osop_config.yml | Adds the default YAML configuration file consumed by the new runner. |
| docs/source/run.md | Updates “Running the toolkit” docs to the new Python + YAML entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
co-pilot suggested change Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…t2' into single_python_script2
There was a problem hiding this comment.
Approved with notes discussed:
--> need to resolve services/centres list so test runs can be easy
--> need to remove some of the terminal output (to verbose)
--> need to set up some regard to coping with the warnings so we dont just forget about them
--> need to do the windows test run
--> need to edit documentations
--> Open above as issues
simple ones covered by #188 , services/centres list clean up already has #183 only missing issue now
|
change the top level driver script to be python based