Skip to content

Removed unnecessary syncs and handles#426

Open
shakedregev wants to merge 3 commits into
developfrom
shaked/copy_data
Open

Removed unnecessary syncs and handles#426
shakedregev wants to merge 3 commits into
developfrom
shaked/copy_data

Conversation

@shakedregev
Copy link
Copy Markdown
Collaborator

@shakedregev shakedregev commented May 29, 2026

The code was synchronizing unnecessarily in GramSchmidt, no matter the backend. This should be handled on the HIP backend (which it now is). But there was a double synching.

Proposed changes

Removed unnecessary syncs. Updates changelogs.

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@shakedregev shakedregev requested review from nkoukpaizan and pelesh May 29, 2026 16:33
@shakedregev shakedregev self-assigned this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant