Dev#9
Merged
Merged
Conversation
…uments to enable new scintillation noise calculation method. Also added get methods for all keywords for consistency
…turns the total variance instead of its square root
…er visualisation of faint sources. Also added scintillation noise to plot_noise()
…lly identify sources in the catalog images
…re now saved to file and plotted during Reducer.create_catalogs(). Previously, only the time-varying background was saved. In addition, get_data() now returns the image header, and noise variances are returned in a dictionary
… (ADS: 2026RASTI...5ag021P)
…e class. Also corrected the read noise value for OPTICAM from 1.1 (slow read; not used) to 1.3 (fast read; default)
…tion of the method. Now, arbitrary filters can be passed to Reducer and all Corrector classes to apply custom filters/kernels as desired. Also made some functions in noise.py methods of Reducer
Collaborator
Author
|
A much-needed update to the docs is also incoming... |
…, changed plot_background_meshes() method to more reliably fall pack to picking random images, and made get_random_image_for_each_filter() a method of Reducer
…atibility with photutils 3.0.0. Also reduced source_matching_tolerance for photometers from 5 to 3 to reduce chances of misidentification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
pick_sources()method toReducerallowing users to manually identify sources that were not automatically catalogued (e.g., if they were too faint).Instrumentclasses now take adiameterparameter giving the diameter of the telescope aperture as anastropyQuantity(i.e., including units). This is used to determine the relative scintillation noise.Instrumentclasses now take anairmass_kwparameter giving the header keyword corresponding to the observation's airmass. This is used to determine the relative scintillation noise. This can be "faked" by defining a customget_airmass()method for a particular instrument if the airmass is not listed but can be calculated from other keywords (e.g., the RA, DEC, and observation timestamp). In the case of OPTICAM, the airmass given in the image headers is a fixed quantity, so we instead use a customget_airmass()method as described above.Reducer.create_catalogs(), we now save the average PSF FWHM and the airmass for each timestamp.Reducerand allCorrectorclasses. This enables support for the 3x3 median filtering recommended by Praez+2026: https://ui.adsabs.harvard.edu/abs/2026RASTI...5ag021P/abstract for long exposures (> 10 s) with OPTICAM.Smaller changes (no impact to users):
Reducerand streamlined the code inplotting.plots.plot_noise()as a result.utils.helpers.propagate_errors()toutils.helpers.combine_variances()to more straightforwardly account for scintillation noise.utils.fits_handlers.get_data()now returns the image, the corresponding header, and a dictionary of noise parameters. This makes it easier to keep track of the various noise contributions.