adding a new AQUFLUX case#974
Conversation
|
jenkins build this please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Looks good for the most part. I think we should amend the header a bit and probably request some additional summary output though.
| -- License: http://opendatacommons.org/licenses/dbcl/1.0/ | ||
|
|
||
| -- Copyright (C) 2023 Equinor | ||
| -- Copyright (C) 2023 SINTEF ICT, Applied Mathematics |
There was a problem hiding this comment.
Are you really sure that you want to list SINTEF ICT here?
There was a problem hiding this comment.
The case is based on AQUFET-01.DATA, which has a copyright claim from 2015. I will update it.
| FAQR | ||
| FAQT | ||
| -- | ||
| -- ANALYTICAL AQUIFERS |
There was a problem hiding this comment.
We don't really support field-level aggregation of aquifer quantities yet so this test case won't write any non-trivial vectors to the summary file. Maybe we could request AAQR and AAQT in addition to the field-level quantities?
There was a problem hiding this comment.
I think AAQR and AAQT are covered by ALL , maybe we should remove FAQR and FAQT, they are also covered by ALL.
There was a problem hiding this comment.
I think AAQR and AAQT are covered by
ALL
Oh, yeah, you're right. I didn't see ALL there. That will absolutely cover the aquifer-related vectors so we don't have request those specifically.
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks for bringing ALL to my attention. That will handle the aquifer-related vectors.
| FAQR | ||
| FAQT | ||
| -- | ||
| -- ANALYTICAL AQUIFERS |
There was a problem hiding this comment.
I think AAQR and AAQT are covered by
ALL
Oh, yeah, you're right. I didn't see ALL there. That will absolutely cover the aquifer-related vectors so we don't have request those specifically.
GitPaean
force-pushed
the
adding_aquflux-02
branch
from
365eaa0 to
07ab7f9
Compare
|
jenkins build this please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. I'll merge into master.
2 participants
referring to discussion in OPM/opm-simulators#4520 .
This case provide more testing capacity and testing some different setup regarding the AQUFLUX. Especially, this case contains two aquifers and they are defined purely in the SCHEDULE section. And it also revealed some bugs when developing PR OPM/opm-simulators#4520 when coming to parallel restart.