Msw refactoring after thermal msw#7043
Closed
GitPaean wants to merge 23 commits into
Closed
Conversation
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this opm-tests=1519 please |
Member
Author
|
jenkins build this opm-tests=1519 failure_report please |
GitPaean
force-pushed
the
msw_refactoring_after_thermal_msw
branch
2 times, most recently
from
b672e30 to
fbcb538
Compare
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
This PR will change the results. Should be reviewed after the PR #6816 . |
Member
Author
|
The refactoring to reuse the created segment fluid state slightly impact the performance, for both thermal and non-thermal running for the cases tested, which is unfortunate. |
including adding tempearture as the primary variable for the MSW. to calculate the enthalpy, for each segment, we generate a SegmentFluidState.
to test the thermal equation solving for MSW
for thermal cases in MultisegmentWell.
instead of using 0, which is not physical
for future record.
Multiply the MSW energy accumulation/flow/perforation terms by energy_scaling_factor_ (the reservoir's BlackOilEnergyScalingFactor) so the energy residual matches the mass-equation scale, improving well-system conditioning and convergence; the connectionRates_ source term stays raw since the reservoir scales the coupling centrally. The energy convergence check now reuses the standard well tolerances instead of hand-tuned constants.
…ture Fall back to first-perforation reservoir temperature when WINJTEMP is unset instead of calling Well::inj_temperature() unconditionally.
Reuse surfaceToReservoirRate for the producing energy connection (now a template over the fluid-state type, extending reservoir Eval on the fly), hoist the segment volume and PVT parameter cache out of their phase loops.
and only applying the pressure and temperature derivative to energy flux.
GitPaean
force-pushed
the
msw_refactoring_after_thermal_msw
branch
from
fbcb538 to
3e55f9d
Compare
and using the calculation in createSegmentFluidState to calculate the surface volume of the segments to reduce duplicated calculation.
remains to be cleaned up.
Member
Author
|
after comparison, #7199 can be the one better to work on. I am closing this one now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #6816, we create a FluidState for each segment.
This PR aims at reusing of the FluidState in the calculating the surface volume of the segment and calculate the fluid properties.