Solving thermal equations for MSW#6816
Open
GitPaean wants to merge 21 commits into
Open
Conversation
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
GitPaean
force-pushed
the
thermal_msw
branch
from
2ff5efa to
bba4fd2
Compare
Member
Author
|
jenkins build this please |
GitPaean
force-pushed
the
thermal_msw
branch
2 times, most recently
from
e1b9b6b to
f676874
Compare
Member
Author
|
jenkins build this please |
GitPaean
force-pushed
the
thermal_msw
branch
3 times, most recently
from
3960982 to
215d308
Compare
GitPaean
force-pushed
the
thermal_msw
branch
3 times, most recently
from
febf6e4 to
75b0fa7
Compare
GitPaean
force-pushed
the
thermal_msw
branch
8 times, most recently
from
1f92b64 to
14530ff
Compare
GitPaean
force-pushed
the
thermal_msw
branch
3 times, most recently
from
48b127b to
cf33559
Compare
Member
Author
|
jenkins build this failure_report please |
3 similar comments
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
jenkins build this failure_report please |
including adding tempearture as the primary variable for the MSW. to calculate the enthalpy, for each segment, we generate a SegmentFluidState.
to test the thermal equation solving for MSW
for thermal cases in MultisegmentWell.
instead of using 0, which is not physical
for future record.
Multiply the MSW energy accumulation/flow/perforation terms by energy_scaling_factor_ (the reservoir's BlackOilEnergyScalingFactor) so the energy residual matches the mass-equation scale, improving well-system conditioning and convergence; the connectionRates_ source term stays raw since the reservoir scales the coupling centrally. The energy convergence check now reuses the standard well tolerances instead of hand-tuned constants.
…ture Fall back to first-perforation reservoir temperature when WINJTEMP is unset instead of calling Well::inj_temperature() unconditionally.
Reuse surfaceToReservoirRate for the producing energy connection (now a template over the fluid-state type, extending reservoir Eval on the fly), hoist the segment volume and PVT parameter cache out of their phase loops.
and only applying the pressure and temperature derivative to energy flux.
Member
Author
|
After some extensive efforts, it looks like to re-use the segment fluid for other non-thermal cases might bring in small impact in performance. It is not easy to resolve perfectly for now. After discussion, it is suggested that we can get this PR in, so the thermal running for MSW can be used. At the same time, the refactoring to re-use segment fluid state to reduce duplicated property calculation can be a continuing efforts to address in the following up PRs. |
Member
Author
|
jenkins build this failure_report please |
- include the energy residual in getResidualMeasureValue - use the first-perforation salt concentration into createFluidState - correct the surfaceToReservoirRate doc comment for the d<=0 fallback
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
jenkins build this please |
| @@ -173,6 +199,16 @@ namespace Opm { | |||
|
|
|||
| // the intial amount of fluids in each segment under surface condition | |||
Member
Author
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add the energy equation for multisegment wells. To calculate the enthalpy for each segment, we create a SegmentFluidState for each segment.
It is possible that we can use more properties from SegmentFluidState as the fluid properties, while I will keep that as a refactoring PR, since it will potentially change the simulation results.
This PR should not change any simulation results when thermal is not activated.