BlackoilModelEbos: some janitoring#4730
Merged
Merged
Conversation
Member
Author
|
jenkins build this please |
bska
reviewed
Jun 30, 2023
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Looks good to me, except for switching <utility> out in favour of <tuple> in BlackoilModelEbos.hpp.
akva2
force-pushed
the
blackoilmodelebos_janitoring
branch
from
5d1c5b8 to
4201d94
Compare
Member
Author
|
jenkins build this please |
bska
approved these changes
Jun 30, 2023
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me now and I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the hopefully non-controversial parts from #4509