Skip to content

fix almost filled with water to 1.0-1e-6#817

Closed
totto82 wants to merge 1 commit into
OPM:masterfrom
totto82:almostEps
Closed

fix almost filled with water to 1.0-1e-6#817
totto82 wants to merge 1 commit into
OPM:masterfrom
totto82:almostEps

Conversation

@totto82

@totto82 totto82 commented Aug 7, 2023

Copy link
Copy Markdown
Member

This is the third part of #803

@totto82

totto82 commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

jenkins build this please

@hnil

hnil commented Aug 8, 2023

Copy link
Copy Markdown
Member

Probably put it in the tag system to be changed. Maybe we should add a type DefaultTolerances where one could get forexample (if it do not exist):

using NumTol = GetPropertyType<TypeTag, DefaultTolerances>;
static constexpr myeps = NumTol::eps;

Reasons:

  • be able to change them
  • avoid putting it as hidden defaut input
  • collect numbers used for numerical hacks ++ one place
  • avoid all the boiler plate assosiated with input parameter i.e. tag definitions, init, register.

@totto82

totto82 commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

benchmark please

@totto82

totto82 commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

Probably put it in the tag system to be changed.

Good point. Especially since it seem to affect lot of cases.

@totto82

totto82 commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

benchmark please

@totto82

totto82 commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Added it to as a parameter here. #816

Will close this for now.

@totto82 totto82 closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants