fix almost filled with water to 1.0-1e-6#817
Closed
totto82 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
jenkins build this please |
Member
|
Probably put it in the tag system to be changed. Maybe we should add a type DefaultTolerances where one could get forexample (if it do not exist): using NumTol = GetPropertyType<TypeTag, DefaultTolerances>;
static constexpr myeps = NumTol::eps;Reasons:
|
Member
Author
|
benchmark please |
Member
Author
Good point. Especially since it seem to affect lot of cases. |
Member
Author
|
benchmark please |
Member
Author
|
Added it to as a parameter here. #816 Will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third part of #803