Skip NNCs created by PINCH if one of the cells is collapsed.#935
Skip NNCs created by PINCH if one of the cells is collapsed.#935blattms wants to merge 2 commits into
Conversation
blattms
added
the
manual:bugfix
|
jenkins build this please |
|
With this the collapsed cell will prevent creation of an NNC. It might turn out that this is not what we want, but it is certainly way better than a model aborting in an assert. Hence I think this should be merged but we should compare behavior with others. |
|
I'd really like to see some unit tests for this in order to assess the behaviour. |
|
Hei, just a frienldy reminder about the schedule for the release:
If we are backporting this, then we need to make a RC3. |
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
Collaped here means that the points of the top and lower plane all coincide. Later those cells will be treated as inactive in preprocess.c when create the grid topology. They qould presemt numerical problems later anyway. Note that this means that these cells (collapsed but PORV larger than MINPVV) will now be present a barrier for PINCH. Fixes the assertion: flow: ./opm/grid/cpgrid/EntityRep.hpp:121: void Dune::cpgrid::EntityRep<codim>::setValue(int, bool) [with int codim = 0]: Assertion `index_arg >= 0' failed.
|
Bugfix from October. Maybe this can make it into the release? There is a test added in case you were wondering. |
blattms
force-pushed
the
bugfix/PINCH-NNC-with-collapsed-cells
branch
from
0f2cfa0 to
188bec4
Compare
|
jenkins build this please |
|
Thanks @blattms for this fix. With it, a big field case (18M cells) was able to run that otherwise gives the mentioned assert. It would be great if this PR can be merged. |
4 participants
Collapsed here means that the points of the top and lower plane on the same pillar coincide.
Later those cells will be treated as inactive in preprocess.c and will not be part of the grid. when we create the grid topology. They would present numerical problems later anyway.
Note that this means that these cells (collapsed but PORV larger than MINPVV) will now be present a barrier preventing creation of a PINCH NNC.
Fixes the assertion:
Closes #505