Renamed functions in opm/grid/polyhedralgrid/grid.hh after changes in previous commit in opm-common#399
Open
rbe051 wants to merge 1 commit into
Open
Renamed functions in opm/grid/polyhedralgrid/grid.hh after changes in previous commit in opm-common#399rbe051 wants to merge 1 commit into
rbe051 wants to merge 1 commit into
Conversation
… previous commit in opm-common
Member
Welcome to OPM! I'll run Jenkins on this although I think it will not pick up any mistakes, as there are no tests for this grid (which is why I think this change was not caught earlier). |
Member
|
jenkins build this please |
akva2
reviewed
Oct 16, 2019
| eclipseGrid->exportZCORN( zcorn ); | ||
| eclipseGrid->exportACTNUM( actnum ); | ||
| std::vector<double> mapaxes = eclipseGrid->getMAPAXES( ); |
Member
|
release or not release, that is the question. |
Member
This is a compile failure for the code in question, so I added it to the release milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a new Post-doc at Norce.