silencing conversion warning due to double->float

[GitPaean]

when -DBUILD_FLOW_FLOAT_VARIANTS=ON

[GitPaean]

jenkins build this please

[Copilot]

Pull request overview

This PR addresses build warnings when compiling with -DBUILD_FLOW_FLOAT_VARIANTS=ON by avoiding implicit/narrowing conversions from double-typed deck/component properties into Scalar (e.g., float) when initializing component parameters in GenericOilGasWaterFluidSystem.

Changes:

• Add explicit static_cast<Scalar>(...) conversions for component properties passed into ComponentParam during initFromState().
• Ensure the critical volume scaling (* 1.e3) is also explicitly converted to Scalar before being stored.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[GitPaean]

now I realized that it shows up when compiling with the PR OPM/opm-simulators#7145 .

[akva2]

looks fine to me, i assume those data tables are doubles because they come from the parser?

[GitPaean]

looks fine to me, i assume those data tables are doubles because they come from the parser?

Yes. They are from CompositionalConfig, which uses double.

[bska]

Very good. I'll merge into master.