[TEST] CO2STORE with multicomponent salt#5159
Conversation
|
jenkins build this please |
4a09417 to
3fead29
Compare
|
jenkins build this please |
|
jenkins build this opm-simulators=7061 please |
3fead29 to
539d71c
Compare
|
jenkins build this opm-simulators=7061 please |
|
@svenn-t I think some of the jenkins errors will go away if you remove the OPM_HOST_DEVICE macro on all the new functions introduced. The macro will make the functions be compiled for GPU as well CPU, and some of the things happening in new functions, such as string operations for example, are not permitted inside gpu kernels. I only briefly looked at the code and the error, I have not compiled it locally to see if that resolves everything. Rule of thumb I guess is to not introduce that macro for now unless it is a part of the specific stuff we want to support on GPU. Hope this helps and sorry for any inconvenience caused by the GPU code! |
Thanks for the comment, I was contemplating calling a mayday for the GPU errors. I guess my problem is that I'm fundamentally changing the meaning of salinity from a std::vector (or the equivalent gpu-version of that) of values to a std::vector of the new SaltArray container. So the BrineCo2Pvt and Co2GasPvt functions that are already marked with OPM_HOST_DEVICE will be affected, I think. Hopefully I can fix at least some of the issues, but might need to call on expert help if/when I fail. |
539d71c to
ed035cf
Compare
|
jenkins build this opm-simulators=7061 please |
ed035cf to
d5e4780
Compare
|
jenkins build this opm-simulators=7061 please |
d5e4780 to
f22a4f3
Compare
|
jenkins build this opm-simulators=7061 please |
f22a4f3 to
e5da77b
Compare
|
jenkins build this opm-simulators=7061 please |
e5da77b to
b77962a
Compare
|
jenkins build this opm-simulators=7061 please |
This PR is to test and benchmark multicomponent salt implementation PRs #5157 and #5158 in CO2STORE PVT calculations.