Skip to content

[TEST] CO2STORE with multicomponent salt#5159

Draft
svenn-t wants to merge 3 commits into
OPM:masterfrom
svenn-t:pvt_multicomp_salt
Draft

[TEST] CO2STORE with multicomponent salt#5159
svenn-t wants to merge 3 commits into
OPM:masterfrom
svenn-t:pvt_multicomp_salt

Conversation

@svenn-t

@svenn-t svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor

This PR is to test and benchmark multicomponent salt implementation PRs #5157 and #5158 in CO2STORE PVT calculations.

@svenn-t svenn-t added the manual:new-feature This is a new feature and should be described in the manual label May 19, 2026
@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from 4a09417 to 3fead29 Compare May 19, 2026 10:22
@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this please

@svenn-t svenn-t added manual:irrelevant This PR is a minor fix and should not appear in the manual and removed manual:new-feature This is a new feature and should be described in the manual labels May 19, 2026
@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from 3fead29 to 539d71c Compare May 19, 2026 12:21
@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@multitalentloes

Copy link
Copy Markdown
Member

@svenn-t I think some of the jenkins errors will go away if you remove the OPM_HOST_DEVICE macro on all the new functions introduced. The macro will make the functions be compiled for GPU as well CPU, and some of the things happening in new functions, such as string operations for example, are not permitted inside gpu kernels. I only briefly looked at the code and the error, I have not compiled it locally to see if that resolves everything. Rule of thumb I guess is to not introduce that macro for now unless it is a part of the specific stuff we want to support on GPU.

Hope this helps and sorry for any inconvenience caused by the GPU code!

@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@svenn-t I think some of the jenkins errors will go away if you remove the OPM_HOST_DEVICE macro on all the new functions introduced. The macro will make the functions be compiled for GPU as well CPU, and some of the things happening in new functions, such as string operations for example, are not permitted inside gpu kernels. I only briefly looked at the code and the error, I have not compiled it locally to see if that resolves everything. Rule of thumb I guess is to not introduce that macro for now unless it is a part of the specific stuff we want to support on GPU.

Hope this helps and sorry for any inconvenience caused by the GPU code!

Thanks for the comment, I was contemplating calling a mayday for the GPU errors. I guess my problem is that I'm fundamentally changing the meaning of salinity from a std::vector (or the equivalent gpu-version of that) of values to a std::vector of the new SaltArray container. So the BrineCo2Pvt and Co2GasPvt functions that are already marked with OPM_HOST_DEVICE will be affected, I think. Hopefully I can fix at least some of the issues, but might need to call on expert help if/when I fail.

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from 539d71c to ed035cf Compare May 19, 2026 13:37
@svenn-t

svenn-t commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from ed035cf to d5e4780 Compare May 20, 2026 07:30
@svenn-t

svenn-t commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from d5e4780 to f22a4f3 Compare May 20, 2026 08:20
@svenn-t

svenn-t commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from f22a4f3 to e5da77b Compare May 21, 2026 16:20
@svenn-t

svenn-t commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

@svenn-t svenn-t force-pushed the pvt_multicomp_salt branch from e5da77b to b77962a Compare May 21, 2026 16:49
@svenn-t

svenn-t commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

jenkins build this opm-simulators=7061 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants