Support nested build directories in sibling search#5091
Open
hakonhagland wants to merge 1 commit into
Open
Conversation
The previous sibling search logic used get_filename_component(NAME) to extract the build directory name, which only returned the last path component. This broke sibling discovery for nested build directories like "builds/debug" — the search would look for "../opm-common/debug" instead of "../opm-common/builds/debug". Use file(RELATIVE_PATH) to compute the full relative path from PROJECT_SOURCE_DIR to PROJECT_BINARY_DIR, then apply that same relative path to the sibling module's source tree. This correctly handles build directories at any depth. The previous strategies (prefix-based naming and common build root) are kept as fallbacks for out-of-source builds. Also add documentation describing the three search strategies and a note about the inline copies in opm-grid and opm-simulators.
hakonhagland
added
the
manual:irrelevant
This was referenced Mar 24, 2026
Contributor
Author
|
jenkins build this opm-grid=1015 opm-simulators=6961 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OpmSiblingSearchmacro usesget_filename_component(NAME)to extract the build directory name, which only returns the last path component. This means nested build directories likebuilds/debugare not supported — the sibling search would look for../opm-common/debuginstead of../opm-common/builds/debug, causing CMake to fail with "could not find opm-common".Changes
get_filename_componentwithfile(RELATIVE_PATH)as the primary search strategy: compute the build directory path relative toPROJECT_SOURCE_DIR, then apply that same relative path to the sibling module's source tree. This correctly handles build directories at any nesting depth (e.g.,builds/debug,builds/release).build-opm-grid→build-opm-common) and common build root with per-module subdirectories.Companion PRs