Activate GLIFTOPT for use in Pyaction and add warning for required keywords#4398
Open
lisajulia wants to merge 1 commit into
Open
Activate GLIFTOPT for use in Pyaction and add warning for required keywords#4398lisajulia wants to merge 1 commit into
lisajulia wants to merge 1 commit into
Conversation
Author
|
jenkins build this opm-simulators=5831 opm-tests=1271 please |
blattms
reviewed
Jan 3, 2025
blattms
left a comment
blattms
left a comment
Member
There was a problem hiding this comment.
Maybe we need to discuss his as there might be hard to detect or undetectable input errors.
lisajulia
force-pushed
the
feature/pyAction-insert-kw-GLIFTOPT
branch
from
8c5d06d to
37af2e3
Compare
lisajulia
force-pushed
the
feature/pyAction-insert-kw-GLIFTOPT
branch
from
37af2e3 to
301e678
Compare
Author
|
jenkins build this opm-simulators=5831 opm-tests=1271 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OPM/opm-simulators#5831 and OPM/opm-tests#1271.
With this PR, the keyword GLIFTOPT is activated for the use in a PYACTION. Since GLIFTOPT needs the keyword LIFTOPT before, I've added a warning: When a keywords that requires other keywords is inserted via a PYACTION, the warning
about the required keywords is added. I've chosen this, since there is no way to access the keywords that have already been processed from inside the PYACTION.