Parse compositional summary keywords#3516
Merged
Merged
Conversation
Contributor
Author
|
jenkins build this please |
bska
reviewed
May 10, 2023
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
This is a good start, but as you say won't actually internalise any of the nodes or output any values to the summary file. Are those tasks intended as follow-up work here, or are we aiming for a minimum support level of "don't stop the run if we encounter these summary keywords"?
Contributor
Author
|
This PR intention is just to avoid stopping the run for the benchmark cases. |
bska
approved these changes
May 11, 2023
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
With the knowledge that this is primarily a stop-gap measure to avoid crashing when running cases featuring these summary keywords I'll merge this. We'll develop actual support for calculating and outputting the values to the summary file as need arises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can run OPM/opm-tests#959 using this implementation.
It parses: "WXMF", "WYMF", "WZMF", "WCGMR", "WCOMR" , but does not output anything.