Skip to content

[HYRAX-1732] Add SignedUrlCache and cache contents of s3credential endpoints#1183

Draft
hannahilea wants to merge 139 commits into
masterfrom
hr/HYRAX-1732-TEA-party-3
Draft

[HYRAX-1732] Add SignedUrlCache and cache contents of s3credential endpoints#1183
hannahilea wants to merge 139 commits into
masterfrom
hr/HYRAX-1732-TEA-party-3

Conversation

@hannahilea
Copy link
Copy Markdown
Contributor

@hannahilea hannahilea commented Oct 29, 2025 •
edited
Loading

Description

  • Cache contents of s3credential endpoint urls
  • Set up and test SignedUrlCache class, as alternative to EffectiveUrlCache

This is a big step toward HYRAX-1732, but does not yet implement the signing itself---end-users will still receive effective urls created via service chaining. This PR adds the main plumbing to set us up for self-signing in the next PR. Includes the self-signing; will close HYRAX-1732 when tested/merged.

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added (well, one! but intentionally b/c that HAS to happen next)
  • Linking works on all Travis builds
  • End-to-end tests added (and run on travis)
  • Tested on SIT
    • Tests pass on SIT! :D
  • Undo temporary Travis changes

@hannahilea
wip get urls from dmrpp
458bbd4
@hannahilea
urls available from EffectiveUrlCache
be8ecf4
@hannahilea
parse s3 credentials from tea endpoint
61ffd33
@hannahilea
Split SignedUrlCache out of EffectiveUrlCache
60271a2
@hannahilea
Split SignedUrlCache out of EffectiveUrlCache
a19ee90
@hannahilea
wip start adding aws sdk dependence
a926716
@hannahilea
Merge branch 'hr/HYRAX-1732-TEA-party-3' of https://github.com/OPENDA…
0a3691d 
…P/bes into hr/HYRAX-1732-TEA-party-3
@hannahilea
Merge branch 'hr/HYRAX-1732-TEA-party-3' of https://github.com/OPENDA…
738ae40 
…P/bes into hr/HYRAX-1732-TEA-party-3
@hannahilea
Add unit test: cache_disabled
db5fb39
@hannahilea
Merge branch 'hr/HYRAX-1732-TEA-party-3' of https://github.com/OPENDA…
ea21df6 
…P/bes into hr/HYRAX-1732-TEA-party-3
@hannahilea
Update test: set_skip_regex
2e0c4b7
@hannahilea
Add test: dump
1bce392
@hannahilea
Fill in credential expiration wip
0652066
@hannahilea
Clear all caches for unit test setup
19a9240
@hannahilea
Add test and fix behavior: invalid response json
ff57cd3
@hannahilea
Test non-http behavior
2466331
@hannahilea
Add test: cache signed url components
b384fd9
@hannahilea
Add test: retrieved signed url components
7a3e8a3
@hannahilea
Add messages to unit test asserts
0142bed
@hannahilea
add test for gets3credentials from endpoing
4792441
@hannahilea
remove stale tests
53e288c
@hannahilea
Clean up
1df8485
@hannahilea
handle timestamp wrangling differently
05d79c8
@hannahilea
update docstrings
c440ee8
@hannahilea
clean up dump to include all cache maps
aa65428
@hannahilea hannahilea marked this pull request as ready for review October 31, 2025 20:08
@hannahilea
Copy link
Copy Markdown
Contributor Author

hannahilea commented Oct 31, 2025

Opening this for review but it should NOT be merged until the next PR is ready to go (and tested on SIT)---don't want to add unnecessary steps to the service chain until it actually buys us the win!

@hannahilea
Copy link
Copy Markdown
Contributor Author

hannahilea commented Oct 31, 2025

There is a fair amount of code added; probably the easiest way to understand it is to start by reading through the test page, since that is fairly comprehensive (I think).

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgallagher59701 jgallagher59701 jgallagher59701 approved these changes

@ndp-opendap ndp-opendap ndp-opendap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannahilea @jgallagher59701 @ndp-opendap