TEDEFO-5032 accept dateFieldId/timeFieldId on Field#78
Merged
Conversation
V1-shape fields.json (re-introduced by TEDEFO-5016) carries these two sibling references on date/time fields. The analyser's strict Jackson mapper (FAIL_ON_UNKNOWN_PROPERTIES) rejected them. Surfaced by the EMD round-trip comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new optional slots to
Fieldso the analyser can deserialise V1-shapefields.json:dateFieldId— set ontimefields, points at the sibling date field.timeFieldId— set ondatefields, points at the sibling time field.These two properties were re-added to V1's exported
fields.jsonby TEDEFO-5016 (recovering shape that was silently dropped after the V1/V2 export split). The analyser's Jackson mapper runs withFAIL_ON_UNKNOWN_PROPERTIES, so any V1 export now fails to load until these slots exist on the analyser-side POJO.Surfaced by the EMD round-trip comparison work (TEDEFO-5032 / Phase 3a) which routes a freshly-exported SDK through
SdkLoaderfor diff-against-EMD.No Drools rule reads either property today; this is purely about being able to deserialise without an
UnrecognizedPropertyException. Getters/setters and the@JsonPropertyOrderentry are added for completeness.Test plan
mvn clean install— existing Cucumber suite stays green