Skip to content

feat: register MdiIcon globally, add new icons, and fix Firebase/SW init duplication #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Talleyrand333 wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

feat: register MdiIcon globally, add new icons, and fix Firebase/SW init duplication #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb8778
feat: register MdiIcon globally, add new icons, and add project docum…
Talleyrand333 Jun 15, 2026
f236969
Merge branch 'staging' into WI-001080
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/base/MdiIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import {
mdiAccountClockOutline,
mdiAccountGroup,
mdiAccountCheck,
mdiAccountTieOutline,
mdiMapMarker,
mdiMapMarkerOutline,
mdiCheckCircle,
Expand Down Expand Up @@ -139,6 +140,7 @@ const iconMap = {
'account-clock-outline': mdiAccountClockOutline,
'account-group': mdiAccountGroup,
'account-check': mdiAccountCheck,
'account-tie-outline': mdiAccountTieOutline,
'map-marker': mdiMapMarker,
'map-marker-outline': mdiMapMarkerOutline,
'check-circle': mdiCheckCircle,
Expand Down
11 changes: 7 additions & 4 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { createApp } from "vue";
import App from "./App.vue";
import MdiIcon from "@/components/base/MdiIcon.vue";
import router from "./router";
import "dayjs/locale/en";
import "dayjs/locale/ar";
Expand Down Expand Up @@ -44,6 +45,7 @@ import "./theme/global.scss";
// REMOVED: v-calendar/style.css — now imported locally in Datepicker.vue
const app = createApp(App);
app.use(pinia);
app.component("MdiIcon", MdiIcon);
Comment thread
Talleyrand333 marked this conversation as resolved.
// VCalendar removed from global registration — see Datepicker.vue for local usage

const animationPage = (baseEl, opts) => {
Expand Down Expand Up @@ -74,13 +76,15 @@ const lang = langStore.lang || "en";
const i18n = initI18n(lang);
app.use(i18n);

router.isReady().then( async () => {
router.isReady().then(async () => {
try {
await registerServiceWorker();
await getFirebaseMessaging();
} catch (e) {
if (e?.message?.includes?.('apiKey')) {
console.warn("Dev mode: Skipping Firebase/SW initialization due to missing environment keys.");
if (e?.message?.includes?.("apiKey")) {
console.warn(
"Dev mode: Skipping Firebase/SW initialization due to missing environment keys.",
);
} else {
console.warn("Firebase/SW initialization failed:", e);
window.__PUSH_NOTIFICATIONS_DISABLED__ = true;
Expand All @@ -90,4 +94,3 @@ router.isReady().then( async () => {
app.mount("#app");
}
});