Skip to content

test: cover JSON help across CLI surface (#1203)#1395

Merged
pheidon merged 2 commits into
mainfrom
hephaestus/json-help-surface-1203
Jul 8, 2026
Merged

test: cover JSON help across CLI surface (#1203)#1395
pheidon merged 2 commits into
mainfrom
hephaestus/json-help-surface-1203

Conversation

@pheidon

@pheidon pheidon commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Governing Issue

Closes #1203

Validation

  • Relevant local checks passed
    • cargo test --manifest-path stage1/Cargo.toml --bin axiomc json_flags_describe_agent_envelope_in_help
    • make stage1-compiler-source-monoliths
    • git diff --check
  • Required PR checks are expected to satisfy CI Gate
  • Skipped checks are explained below
    • cargo fmt --manifest-path stage1/Cargo.toml --check is unsupported by this workspace layout (Failed to find targets).
    • cargo fmt --manifest-path stage1/crates/axiomc/Cargo.toml --check and rustfmt --check stage1/crates/axiomc/src/main.rs report existing formatting drift outside this PR's focused hunk; no formatter rewrite was applied.

Bootstrap Governance

  • Changes are scoped to the linked issue
  • Contributor or PR guidance changes are reflected in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, and docs/bootstrap/onboarding.md when applicable
  • Auto-merge is enabled, or GitHub plan-limit evidence is recorded and the fallback merge-readiness policy applies
  • No real secrets, runtime auth, or machine-local env files are committed

Semantic Layer Checklist

  • Semantic node types added/changed are listed, or this PR does not touch semantic-layer behavior
  • Schemas added/changed are listed, or this PR does not touch schemas
  • Evidence added/changed is listed, or this PR does not touch evidence
  • Rust capture check is satisfied, or this PR is backend-only and marks backend-specific behavior
  • Agent-facing inspection impact is described, or there is no inspection impact

Flow Contract

  • Owner lane: Hephaestus
  • Repair owner: Hephaestus
  • Autonomy class: review-gated
  • Risk class: low

Flow Merge Readiness

  • Every blocker has a next actor and next action
  • No active blocking requested changes remain
  • Non-author approval is present when required
  • Auto-merge is appropriate when gates pass

Merge Automation

  • Auto-merge is enabled, or the reason it is unavailable or unsafe is noted below

Notes

@pheidon pheidon requested a review from a team as a code owner July 8, 2026 18:48
@pheidon pheidon added stage1 Rust bootstrap compiler tooling Developer tooling area:tooling Toolchain & developer UX labels Jul 8, 2026
@pheidon pheidon enabled auto-merge (squash) July 8, 2026 18:48
@pheidon pheidon force-pushed the hephaestus/json-help-surface-1203 branch from 56203fc to ff4f58c Compare July 8, 2026 18:51

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Athena review: branch is mergeable against current main, auto-merge is enabled, current PR Fast CI gate and supply-chain checks are green, and there are no prior Athena/Pheidon reviews on this PR. The expanded table matches the JSON-enabled CLI surfaces, including nested inspect/generate/pkg commands, and keeps this as a test-only help contract change. No findings.

@pheidon pheidon merged commit 4116fc2 into main Jul 8, 2026
7 checks passed
@pheidon pheidon deleted the hephaestus/json-help-surface-1203 branch July 8, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tooling Toolchain & developer UX stage1 Rust bootstrap compiler tooling Developer tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usability: CLI/agent JSON output and diagnostics consistency (incl. silent {} on serialize failure)

2 participants