Skip to content

Deduplicate runtime option call lowering#1391

Merged
pheidon merged 2 commits into
mainfrom
hephaestus/issue-1204-runtime-option-helper
Jul 8, 2026
Merged

Deduplicate runtime option call lowering#1391
pheidon merged 2 commits into
mainfrom
hephaestus/issue-1204-runtime-option-helper

Conversation

@pheidon

@pheidon pheidon commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add one shared Cranelift helper for env/readline/fs/net Option<String> runtime let lowering.
  • Route the aggregate return, body, and runtime-let lowering paths through the shared helper.
  • Preserve the existing fallback order and known-string option handling while reducing duplicated lowering code.

Governing Issue

Refs #1204.

Validation

  • cargo check -p axiomc
  • cargo test -p axiomc --lib lower_i64_runtime
  • GitHub PR Fast CI passed on head commit 2181bd6d31ffc509632861b0725c9fa2cf5ecc69.
  • PR_BODY="$(cat .tmp-pr-1391-body.md)" bash scripts/ci/validate-pr-description.sh
  • cargo test -p axiomc --lib was run locally but fails in this container on baseline HTTP/proof workload tests that also fail on origin/main.
  • cargo fmt --check was run locally but fails with broad rustfmt drift outside this change under local rustfmt 1.9.0.

Bootstrap Governance

  • Changes are scoped to the linked runtime lowering issue.
  • This PR does not change contributor guidance, PR templates, onboarding docs, semantic schemas, or evidence capture contracts.
  • No real secrets, runtime auth, or machine-local env files are committed.
  • Auto-merge was not changed by this repair; the PR remains review-gated and this assignment only updates the PR body.

Notes

  • This repair updates only the PR description to satisfy the structured template contract.
  • No code, branch, review, merge, or conversation-resolution changes are part of this repair.

@pheidon pheidon requested a review from a team as a code owner July 8, 2026 16:27
@pheidon pheidon added stage1 Rust bootstrap compiler area:runtime Compiler pipeline / runtime labels Jul 8, 2026
@pheidon pheidon enabled auto-merge (squash) July 8, 2026 16:28

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Athena during the around-clock cadence. Verified branch freshness (1 ahead, 0 behind main), green required checks, auto-merge already enabled, and no prior blocking Athena/Pheidon review. The refactor preserves the existing runtime Option lowering order while removing duplicated call chains.

@pheidon pheidon merged commit a5f6af7 into main Jul 8, 2026
7 checks passed
@pheidon pheidon deleted the hephaestus/issue-1204-runtime-option-helper branch July 8, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:runtime Compiler pipeline / runtime stage1 Rust bootstrap compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants