fix(jupyterhub): use cluster DNS for internal Hub API calls#6
Open
idirze wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure JupyterHub to use the Kubernetes fully qualified service DNS name for internal Hub communication via
hub_connect_url.This ensures spawned notebook pods receive a
JUPYTERHUB_API_URLthat uses the.svc.cluster.localDNS suffix, for example:This allows internal Kubernetes service traffic to be excluded from the corporate proxy using a generic
NO_PROXY/no_proxysuffix:Without this, notebook pods may try to reach the internal Hub API through the corporate proxy and receive
403 Access Denied by proxy.Related Issue
OKDP/trino-opal-example-policy#2
Type of Change
How to Test
After deploying the chart change, restart the Hub and the affected notebook server.
Verify that a new single-user notebook pod receives the Kubernetes FQDN-based Hub API URL:
Expected output:
Verify that Requests does not select the corporate proxy for the Hub API URL:
Expected output:
Finally, verify that the notebook can call the Hub API without receiving a corporate proxy
403response.