Skip to content

refactor(dds): DomainParticipant の責務を分離#103

Merged
OJII3 merged 5 commits into
mainfrom
refactor/domain-participant-testability
Jun 29, 2026
Merged

refactor(dds): DomainParticipant の責務を分離#103
OJII3 merged 5 commits into
mainfrom
refactor/domain-participant-testability

Conversation

@OJII3

@OJII3 OJII3 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • DomainParticipant から lease expiry 監視を LeaseExpiryMonitor に分離
  • SEDP add / unregister の副作用と例外処理を SedpEndpointAdvertiser に分離
  • user endpoint の writer / reader / endpoint data 生成を ParticipantEndpointFactory に分離し、単体テストを追加

Test Plan

  • PASS: dotnet test tests/rosettadds.Tests/rosettadds.Tests.csproj --no-restore --filter FullyQualifiedName~LeaseExpiryMonitorTests
  • PASS: dotnet test tests/rosettadds.Tests/rosettadds.Tests.csproj --no-restore --filter FullyQualifiedName~SedpEndpointAdvertiserTests
  • PASS: dotnet test tests/rosettadds.Tests/rosettadds.Tests.csproj --no-restore --filter FullyQualifiedName~ParticipantEndpointFactoryTests
  • PASS: dotnet test tests/rosettadds.Tests/rosettadds.Tests.csproj --no-restore --filter "FullyQualifiedNameParticipantEndpointFactoryTests|FullyQualifiedNamePublisherSubscriptionMatchedTests|FullyQualifiedName~ServiceClientLoopbackTests"
  • PASS: .github/scripts/check_unity_meta.sh
  • FAIL (baselineでも再現): dotnet test rosettadds.sln --no-restore

Known Verification Issue

作業前ベースラインおよび作業後の solution 全体テストで、ROSettaDDS.Tests.Integration.PublisherBatchTests.PublishManyAsync_は_バッチサイズが_MaxSamples_を超えても_use_after_return_を起こさない が失敗します。期待 2000 件に対して 256 件で timeout しますが、該当テスト単体では PASS します。今回の抽出変更前から再現しているため、この PR 起因ではない既存の不安定テストとして扱っています。

@OJII3 OJII3 marked this pull request as ready for review June 29, 2026 18:58
@OJII3 OJII3 merged commit 408f2d3 into main Jun 29, 2026
1 check passed
@OJII3 OJII3 deleted the refactor/domain-participant-testability branch June 29, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant