refactor(dds): DomainParticipant の責務を分離#103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
ParticipantEndpointFactoryTests|FullyQualifiedNamePublisherSubscriptionMatchedTests|FullyQualifiedName~ServiceClientLoopbackTests"Known Verification Issue
作業前ベースラインおよび作業後の solution 全体テストで、ROSettaDDS.Tests.Integration.PublisherBatchTests.PublishManyAsync_は_バッチサイズが_MaxSamples_を超えても_use_after_return_を起こさない が失敗します。期待 2000 件に対して 256 件で timeout しますが、該当テスト単体では PASS します。今回の抽出変更前から再現しているため、この PR 起因ではない既存の不安定テストとして扱っています。