Conversation
anthonysena
approved these changes
Jun 19, 2026
anthonysena
left a comment
anthonysena
left a comment
Collaborator
There was a problem hiding this comment.
Looks great thank you for implementing this feature!
Merge branch 'develop' into 318 # Conflicts: # inst/csv/jarChecksum.txt # inst/java/featureExtraction-3.13.0.jar # tests/testthat/test-GetDefaultCovariates.R # vignettes/CreatingCustomCovariateBuilders.Rmd
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #331 +/- ##
===========================================
+ Coverage 84.57% 84.59% +0.02%
===========================================
Files 16 16
Lines 1692 1701 +9
===========================================
+ Hits 1431 1439 +8
- Misses 261 262 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ginberg
added a commit
that referenced
this pull request
Jun 28, 2026
* cran submission * add features for observation.value_as_number (#328) * add features for observation.value_as_number * rename MeasurementValue.sql to DomainValueAsNumber.sql * update vignette (#330) * set specific column order for covariates (#329) * set specific column order for covariates * test * minCharacterizationCount (#331) * version update * update doc * update doc * remove warnings * cran updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #318
note: this PR partly overlaps with #330 with regard to vignette updates