Skip to content

core install: pass sem into every pip call#302

Merged
kba merged 1 commit into
masterfrom
try-to-fix-pip-races
Mar 23, 2022
Merged

core install: pass sem into every pip call#302
kba merged 1 commit into
masterfrom
try-to-fix-pip-races

Conversation

@bertsky

@bertsky bertsky commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@stweil

stweil commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

This conflicts with #299.

@bertsky

bertsky commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator Author

This conflicts with #299.

I don't care TBH – we are still trying to solve the deployment misery (see CI failures for CUDA variant and recent -j switching), which is urgent.

This is necessary to get a true separation of pip calls between (possibly parallel) venvs.

@kba

kba commented Mar 23, 2022

Copy link
Copy Markdown
Member

This conflicts with #299.

I think it's a counterargument to #299. And it seems to fix the issue at hand (race condition while installing core). Let's merge and hope for the best. If CD still fails, I will push the images manually.

@kba kba merged commit 115bed0 into master Mar 23, 2022
@kba

kba commented Mar 23, 2022

Copy link
Copy Markdown
Member

This conflicts with #299.

I think it's a counterargument to #299.

Wrong, sry. We still don't need $(PIP) in the ocrd_all Makefile, only in dependent packages.

@stweil stweil deleted the try-to-fix-pip-races branch March 23, 2022 12:19
@stweil

stweil commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

I fixed the merge conflict in #299 (now for the second time), so it is ready for merging again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants