Skip to content

Shorten path for SUB_VENV and define it only on the first make level#300

Merged
stweil merged 1 commit into
OCR-D:masterfrom
stweil:subvenv
Mar 23, 2022
Merged

Shorten path for SUB_VENV and define it only on the first make level#300
stweil merged 1 commit into
OCR-D:masterfrom
stweil:subvenv

Conversation

@stweil

@stweil stweil commented Mar 19, 2022

Copy link
Copy Markdown
Collaborator

There is no need for the additional directory "local" (which can
also be confused with "locale" on the same level).

Signed-off-by: Stefan Weil sw@weilnetz.de

There is no need for the additional directory "local" (which can
also be confused with "locale" on the same level).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil

stweil commented Mar 19, 2022

Copy link
Copy Markdown
Collaborator Author

This is also part of pull request #295.

@stweil stweil requested review from bertsky and kba March 23, 2022 10:02

@bertsky bertsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@stweil stweil merged commit cb9a94b into OCR-D:master Mar 23, 2022
@stweil stweil deleted the subvenv branch March 23, 2022 10:57

@kba kba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide a migration script/makefile target, otherwise people with a local installation will have gigabytes of obsolete data in /local/sub-venv, won't they?

@stweil

stweil commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator Author

Do you think that people reuse their local venvs? I personally don't do so because it does not really work good to run incremental builds. Typically I create fresh venvs with the date in the name and run fresh builds. And from time to time I remove the old venvs.

A notice in the release notes would be sufficient in my opinion.

@bertsky

bertsky commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

A notice in the release notes would be sufficient in my opinion.

I concur. (Migrating venvs is not possible BTW – FS paths are fixed.)

@kba

kba commented Mar 23, 2022

Copy link
Copy Markdown
Member

Do you think that people reuse their local venvs?

They do, sometimes even with a weekly cronjob. Just yesterday I told @lena-hinrichsen that git pull; make all should be enough after an update. But we can change that of course and tell people to build from scratch for every new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants