Skip to content

Add GitHub action for make all#292

Merged
stweil merged 1 commit into
OCR-D:masterfrom
stweil:github-action
Mar 9, 2022
Merged

Add GitHub action for make all#292
stweil merged 1 commit into
OCR-D:masterfrom
stweil:github-action

Conversation

@stweil

@stweil stweil commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

It is currently configured to be triggered manually either from the
GitHub web frontend or from the GitHub API.

make all can be run with a selected version of Ubuntu and Python,
or a matrix of versions.

Signed-off-by: Stefan Weil sw@weilnetz.de

It is currently configured to be triggered manually either from the
GitHub web frontend or from the GitHub API.

`make all` can be run with a selected version of Ubuntu and Python,
or a matrix of versions.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil

stweil commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator Author

As soon as this PR was merged, we can run our first GitHub action for the full matrix of
[ubuntu-18.04, ubuntu-20.04] x [Python 3.6, 3.7, 3.8, 3.9, 3.10] (10 runs).

For both versions of Ubuntu, Python 3.6 and 3.7 (and 3.8 with PR #289) should build fine, while the other Python versions are expected to abort when trying to get Tensorflow 1.5.

@stweil

stweil commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator Author

Example of GitHub action with full test matrix: https://github.com/stweil/ocrd_all/actions/runs/1947808212.

Even with PR #289, only Python 3.6 builds all targets. Python 3.7 and 3.8 fail when building cor-asv-ann-check.

@bertsky

bertsky commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

Even with PR #289, only Python 3.6 builds all targets. Python 3.7 and 3.8 fail when building cor-asv-ann-check.

That seems to be coming from new upstream conflicts between Tensorflow and Scikit-Image. We recently encountered that in ocrd_pc_segmentation, but it seems to be wider. Needs to be investigated.

@stweil stweil merged commit 196716b into OCR-D:master Mar 9, 2022
@stweil stweil deleted the github-action branch March 9, 2022 21:23
@stweil

stweil commented Mar 9, 2022

Copy link
Copy Markdown
Collaborator Author

I rebased and merged my latest pull requests and started now the first GitHub action for OCR-D/ocrd_all with the full build matrix: https://github.com/OCR-D/ocrd_all/actions/runs/1959782165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants