Skip to content

update ocrd_kraken#288

Merged
stweil merged 4 commits into
OCR-D:masterfrom
bertsky:update-kraken
Mar 18, 2022
Merged

update ocrd_kraken#288
stweil merged 4 commits into
OCR-D:masterfrom
bertsky:update-kraken

Conversation

@bertsky

@bertsky bertsky commented Feb 17, 2022

Copy link
Copy Markdown
Collaborator

Even if still PR, the newer ocrd_kraken is already usable and therefore should be re-activated.

(Note: will probably work even better after applying the recent suggestions and updating here again.)

@bertsky bertsky requested a review from kba February 17, 2022 22:58
@bertsky

bertsky commented Feb 17, 2022

Copy link
Copy Markdown
Collaborator Author

Note: CI stops short due to a CircleCI syntax error (min instead of m for no_output_timeout) – which I have already fixed in master, but strangely it does not ever apply.

@bertsky bertsky mentioned this pull request Feb 19, 2022
@kba

kba commented Mar 4, 2022

Copy link
Copy Markdown
Member

Note: CI stops short due to a CircleCI syntax error (min instead of m for no_output_timeout) – which I have already fixed in master, but strangely it does not ever apply.

Did you merge the fix in master back to this branch? I did for your
PR #289 and it's running again.

@bertsky

bertsky commented Mar 4, 2022

Copy link
Copy Markdown
Collaborator Author

Did you merge the fix in master back to this branch? I did for your
PR #289 and it's running again.

I didn't know CI config is taken from the very branch it applies to.

CI failure: see here

@stweil

stweil commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator

What about OCR-D/ocrd_kraken#33? I think we should require kraken 3.0.9 or even 4.0.

@stweil

stweil commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator

Maybe PR #297 which also touches the Makefile rules for ocrd_kraken can be integrated here, too (or applied after this PR to avoid a merge conflict here).

@bertsky

bertsky commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator Author

@stweil,

What about OCR-D/ocrd_kraken#33? I think we should require kraken 3.0.9 or even 4.0.

I don't understand your question. This PR sets ocrd_kraken to PR 33, which already requries kraken>=3.0 in ocrd_all.

Maybe PR #297 which also touches the Makefile rules for ocrd_kraken can be integrated here, too (or applied after this PR to avoid a merge conflict here).

No, it's the other way round. This PR is minimal and has been hanging here for one month already.

@stweil

stweil commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

No, it's the other way round. This PR is minimal and has been hanging here for one month already.

To bring it to the point: this PR breaks some build configurations which no longer work when it is applied. I only suggested to fix that before the PR is merged instead of first breaking and then fixing.

@bertsky

bertsky commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator Author

To bring it to the point: this PR breaks some build configurations which no longer work when it is applied. I only suggested to fix that before the PR is merged instead of first breaking and then fixing.

You mean Python 3.10? That can wait. Users should finally have ocrd_kraken back. Merging is on your side.

@stweil stweil merged commit dd62a5b into OCR-D:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants