[19.0][MIG] base_user_role_company: Migration to 19.0

[clement-gouin]

NOTE: UPDATED COPY OF STALE #383

(there were no updates since 15th of october 2025)

Scope

• base_user_role_company only

Summary

• Migrate to Odoo 19.0 following OCA guide.
• Override parent unique constraint with company-aware one: UNIQUE(user_id, role_id, company_id).
• Tests aligned with 19.0 (group_ids API).

(differences from original):

• rebased branch 19.0
• used args/kwargs on every super() call
• removed temporary dependency [19.0][MIG] base_user_role_company: Migration to 19.0 #383 (comment)
• applied suggested fix [19.0][MIG] base_user_role_company: Migration to 19.0 #383 (comment)

Pre-commit

• Verified locally; no additional changes applied beyond auto-fixes.

Tests

# init
docker network create -d bridge odoo_net
docker run --rm --name odoo_db --network=odoo_net --hostname odoo_db --env POSTGRES_DB=odoo --env POSTGRES_USER=odoo --env POSTGRES_PASSWORD=odoo -d postgres:18

# test
docker run --rm -it -v $PWD:/mnt/extra-addons --network=odoo_net odoo:19 \
    /usr/bin/odoo server --db_host odoo_db -d odoo --db_password odoo  --db_user odoo --without-demo --log-level=info --stop-after-init --no-http \
    -i base_user_role,base_user_role_company --test-enable --test-tags "/base_user_role_company"

# shutdown
docker kill odoo_db
docker network rm odoo_net

results:

2026-03-31 10:09:22,219 1 INFO odoo odoo.tests.stats: base_user_role_company: 9 tests 0.55s 834 queries 
2026-03-31 10:09:22,219 1 INFO odoo odoo.tests.result: 0 failed, 0 error(s) of 5 tests when loading database 'odoo' 

[clement-gouin]

I'm looking at coverage on codecov and I will try to add more tests to meet the requirements

[legalsylvain]

better to use args / kwargs syntax, to make the code more resilient in the futur.
don't you think ?

[clement-gouin]

Sure thing, I've updated the PR with args/kwargs on every super() call

[clement-gouin]

Added more tests and less edits from base code

[clement-gouin]

Can I get any update on this subject ? I've tested this branch on a real 19.0 production database and it works the same as 18.0

[CRogos]

Could you squash all migration commits (red box) and also sqush the CI commits like the yellow marked (there are more)?

I'll test when runboat is available.

[CRogos]

I think this syntax is more readable...

from odoo import Command

Suggested change

	(0, 0, {"role_id": self.roleA.id}),
	(0, 0, {"role_id": self.roleB.id, "company_id": self.company1.id}),
	(0, 0, {"role_id": self.roleC.id, "company_id": self.company1.id}),
	(0, 0, {"role_id": self.roleC.id, "company_id": self.company2.id}),
	Command.create({"role_id": self.roleA.id}),
	Command.create({"role_id": self.roleB.id, "company_id": self.company1.id}),
	Command.create({"role_id": self.roleC.id, "company_id": self.company1.id}),
	Command.create({"role_id": self.roleC.id, "company_id": self.company2.id}),

[clement-gouin]

I'v updated the tests in the last commit

[CRogos]

Suggested change

	"company_ids": [(6, 0, [self.company1.id, self.company2.id])],
	"role_line_ids": [
	(0, 0, {"role_id": self.roleA.id, "company_id": self.company3.id}),
	"company_ids": [Command.set([self.company1.id, self.company2.id])],
	"role_line_ids": [
	Command.create({"role_id": self.roleA.id, "company_id": self.company3.id}),

[clement-gouin]

I'v updated the tests in the last commit

[CRogos]

from odoo import Command

Suggested change

	"company_ids": [(fields.Command.set([cls.company1.id]))],
	"role_line_ids": [
	(fields.Command.create({"role_id": cls.roleA.id})),
	(
	fields.Command.create(
	{
	"role_id": cls.roleB.id,
	"date_to": fields.Date.today() + timedelta(days=1),
	}
	)
	),
	],
	"company_ids": [(Command.set([cls.company1.id]))],
	"role_line_ids": [
	(Command.create({"role_id": cls.roleA.id})),
	(
	Command.create(
	{
	"role_id": cls.roleB.id,
	"date_to": fields.Date.today() + timedelta(days=1),
	}
	)
	),
	],

[clement-gouin]

I'v updated the tests in the last commit

[clement-gouin]

Could you squash all migration commits (red box) and also sqush the CI commits like the yellow marked (there are more)?

I'll test when runboat is available.

Done.

[clement-gouin]

Hi, I've just:

• Rebased the PR with the latest version of the 19.0 branch
• Squashed mentioned commits
• Applied mentioned tests syntax

[CRogos]

@clement-gouin there is still more to squash, as already mentioned. (oca-travis, OCA-git-bot, oca-transbot, ...)
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

[clement-gouin]

@clement-gouin there is still more to squash, as already mentioned. (oca-travis, OCA-git-bot, oca-transbot, ...) https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

My bad, I thought the contributor of #383 was already following the guidelines, I didn't check prior to my edits.

This is now done as indicated in the documentation.

[CRogos]

Migration LGTM, but I am not very aware of the security perspective. Wouldn't it be a good idea to add some demo data for easier testing?

Some improvement suggestions:
Shall we change this to a tag view like in the user page?

Should we add optional columns (companies also as tag cloud)?