Skip to content

[19.0][FIX] purchase_order_line_description: preserve manual descriptions - #3144

Open
chienandalu wants to merge 1 commit into
OCA:19.0from
moduon:19.0-fix-purchase-order-line-description
Open

[19.0][FIX] purchase_order_line_description: preserve manual descriptions#3144
chienandalu wants to merge 1 commit into
OCA:19.0from
moduon:19.0-fix-purchase-order-line-description

Conversation

@chienandalu

@chienandalu chienandalu commented Aug 11, 2026

Copy link
Copy Markdown
Member

The purchase line widget re-added the product name when users edited a line description, even though this module deliberately uses only the purchase description:

  • Keep manually entered purchase descriptions unchanged and
  • Added a regression tour.

https://www.loom.com/share/bd1acbb99f7943458eefcaa00df311f1

please review @yajo @fcvalgar

twin PR:

cc @moduon MT-15180

@OCA-git-bot OCA-git-bot added series:19.0 mod:purchase_order_line_description Module purchase_order_line_description labels Aug 11, 2026
@chienandalu
chienandalu force-pushed the 19.0-fix-purchase-order-line-description branch 4 times, most recently from 0c4ab5f to 5276090 Compare August 12, 2026 09:15
The purchase line widget re-added the product name when users edited a line
description, even though this module deliberately uses only the purchase
description. Keep manually entered purchase descriptions unchanged and cover
the browser flow with a regression tour.

MT-15180
@chienandalu
chienandalu force-pushed the 19.0-fix-purchase-order-line-description branch from 5276090 to a476ba2 Compare August 13, 2026 10:08
@chienandalu

Copy link
Copy Markdown
Member Author

please review @fcvalgar @yajo

@fcvalgar fcvalgar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chienandalu! The fix behaves as expected and the manually entered purchase order line descriptions are now preserved correctly.

The following tests were performed:
Test 1: OK - A product with a purchase description was added to a request for quotation, and only the purchase description was displayed without the product name.
Test 2: OK - The purchase order line description was edited manually, and the entered text was preserved without re-adding the product name.
Test 3: OK - The request for quotation was saved and reloaded, and the manually edited description remained unchanged.
Test 4: OK - The description was modified after confirming the purchase order, and the new manual value was preserved correctly.
Test 5: OK - The purchase order line description was cleared manually, and the product name was not automatically restored.
Test 6: OK - Section and note lines continued to work correctly and were not affected by the change.
LGTM

Image Image

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants