[19.0][FIX] purchase_request: prevent double-counting of purchase request line quantities in PO lines - #2999
Merged
Conversation
Contributor
Author
HviorForgeFlow
approved these changes
Mar 20, 2026
MiquelRForgeFlow
approved these changes
Mar 20, 2026
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at f27bd53. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where purchase order line quantities were over-counted by 1 when converting purchase requests to RFQs/POs.
The wizard now links the purchase request line to the PO line only after the correct quantity is calculated and written, preventing double-counting.
The _calc_new_qty method now simply sums all linked lines, matching Odoo 19.0 core logic.
The test cases are failing in the following PRs: #2996, #2997, #2998.