[ADD] no-translation-format: Do not use format with translations

[SirPyTech]

The check was added in OCA/pylint-odoo#304, then has been removed in OCA/pylint-odoo#396 because it was supposedly checked by https://github.com/OCA/odoo-pre-commit-hooks, but I can't find such check.

@moylop260 looks like you are involved in all the related changes, please let me know what you think.

[moylop260]

Hi @SirPyTech

Good catch!

Checking why this check was removed, I have found the following main issue:

• pylint checks to pre-commit hooks: Deprecate checks in pro pre-commit hooks pylint-odoo#393

Notice the following note:

check	action	reference	Notes
str-format-used	deprecate		py3 fix the errors related to str.format method

I think I was confused with the following prefer-other-formatting case

• [ADD] prefer-other-formatting: Avoid use of ''.format pylint-odoo#65
  It was already fixed from py3 related with unicode issues using format

But the no-translation-format is a different issue related to security using format

So, I think it is valid to have it and it should not be deleted from pylint-odoo since that AST python processing is managed from pylint-odoo instead of odoo-pre-commit-hooks

Could you migrate it to pylint-odoo, please?

[moylop260]

Drop it

I just have create the following PR:

• [ADD] translation-injection: Detect str.format() inside Odoo translation methods pylint-odoo#569