[19.0] [MIG] account_invoice_margin_sale superseed#258
Open
eugenios73 wants to merge 24 commits into
Open
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/es/
[UPD] Update account_invoice_margin_sale.pot [UPD] README.rst account_invoice_margin_sale 13.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/
[UPD] Update account_invoice_margin_sale.pot [UPD] README.rst
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-14.0/margin-analysis-14.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-14-0/margin-analysis-14-0-account_invoice_margin_sale/es/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/fr_FR/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/es/
- Include context keys for avoiding mail operations overhead.
…rder When sale_margin_security is also installed. Closes OCA#194
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/it/
eugenios73
changed the title
eugenios73
force-pushed
the
19.0-mig-account_invoice_margin_sale-superseed
branch
2 times, most recently
from
2ffec71 to
200c44c
Compare
Author
|
@dreispt I create this superseded from inactivity of the superseded PR, appling the modifications of your comment. Pleas can you review this PR? Thanks |
|
Adding yourself as a contributor is not reasonable here IMO. |
eugenios73
force-pushed
the
19.0-mig-account_invoice_margin_sale-superseed
branch
from
200c44c to
7089e0a
Compare
eugenios73
force-pushed
the
19.0-mig-account_invoice_margin_sale-superseed
branch
from
7089e0a to
3001864
Compare
Member
Last change to the contributors list was on the 17.0 migration. |
Well sure, after the git history is rewritten https://github.com/OCA/margin-analysis/compare/200c44c4d41afe0da986bf086d99622f80ef223d..7089e0a4b50f31bbf2bd2df0b3e3a79fdec557ee |
stferraro
approved these changes
May 28, 2026
BhaveshHeliconia
suggested changes
Jun 3, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Consider using BaseCommon instead of TransactionCase. In this case, there’s no need to redefine cls.env with tracking_disable=True, and res.partner is already available via BaseCommon. This would help simplify and optimize the test code.
eugenios73
force-pushed
the
19.0-mig-account_invoice_margin_sale-superseed
branch
from
3001864 to
b67d6cf
Compare
OCA-git-bot
added
series:19.0
mod:account_invoice_margin_sale
Contributor
|
@eugenios73 could you please check the failing pre-commit? |
eugenios73
force-pushed
the
19.0-mig-account_invoice_margin_sale-superseed
branch
from
b67d6cf to
639ae95
Compare
Author
|
@BhaveshHeliconia thanks for your review. Problems solved. |
BhaveshHeliconia
approved these changes
Jun 4, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code review LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superseeded #255
Depends on #254