-
-
Notifications
You must be signed in to change notification settings - Fork 220
[18.0][ADD] maintenance_equipment_availability #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
smorita7749
wants to merge
1
commit into
OCA:18.0
Choose a base branch
from
qrtl:18.0-add-maintenance-equipment-availability
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| ================================== | ||
| Maintenance Equipment Availability | ||
| ================================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:7785d6d9fa83b76b5b3f87e5d8e180b6ee18bfae95a90226b908c8b19b84a4a0 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/maintenance/tree/18.0/maintenance_equipment_availability | ||
| :alt: OCA/maintenance | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/maintenance-18-0/maintenance-18-0-maintenance_equipment_availability | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/maintenance&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module adds a pass/fail maintenance result to maintenance requests | ||
| and computes equipment availability from the latest completed | ||
| maintenance request with a result. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| When a maintenance request is completed (it reaches a done stage), set | ||
| its Maintenance Result to Passed or Failed. The equipment availability | ||
| is then computed from the latest completed request by completion date. | ||
|
|
||
| - Passed: the equipment is available. | ||
| - Failed: the equipment is unavailable. | ||
| - No result yet: the equipment availability is unknown. | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/maintenance/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_equipment_availability%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Quartile | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - `Quartile <https://www.quartile.co>`__: | ||
|
|
||
| - Shinnosuke Morita | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/maintenance <https://github.com/OCA/maintenance/tree/18.0/maintenance_equipment_availability>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Copyright 2026 Quartile (https://www.quartile.co) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright 2026 Quartile (https://www.quartile.co) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "Maintenance Equipment Availability", | ||
| "summary": "Compute equipment availability from maintenance request results", | ||
| "version": "18.0.1.0.0", | ||
| "development_status": "Beta", | ||
| "category": "Maintenance", | ||
| "website": "https://github.com/OCA/maintenance", | ||
| "author": "Quartile, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "depends": ["maintenance"], | ||
| "data": [ | ||
| "views/maintenance_request_views.xml", | ||
| "views/maintenance_equipment_views.xml", | ||
| ], | ||
| "installable": True, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Copyright 2026 Quartile (https://www.quartile.co) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import maintenance_request | ||
| from . import maintenance_equipment |
70 changes: 70 additions & 0 deletions
70
maintenance_equipment_availability/models/maintenance_equipment.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,70 @@ | ||||
| # Copyright 2026 Quartile (https://www.quartile.co) | ||||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||||
|
|
||||
| from odoo import api, fields, models | ||||
|
|
||||
|
|
||||
| class MaintenanceEquipment(models.Model): | ||||
| _inherit = "maintenance.equipment" | ||||
|
|
||||
| availability_state = fields.Selection( | ||||
| selection=[ | ||||
| ("unknown", "Unknown"), | ||||
| ("available", "Available"), | ||||
| ("unavailable", "Unavailable"), | ||||
| ], | ||||
| compute="_compute_availability", | ||||
| store=True, | ||||
| readonly=True, | ||||
| string="Availability", | ||||
| ) | ||||
| latest_maintenance_result_request_id = fields.Many2one( | ||||
| comodel_name="maintenance.request", | ||||
| compute="_compute_availability", | ||||
| store=True, | ||||
| readonly=True, | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
| string="Latest Result Request", | ||||
| ) | ||||
| latest_maintenance_result_date = fields.Date( | ||||
| compute="_compute_availability", | ||||
| store=True, | ||||
| readonly=True, | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
| string="Latest Result Date", | ||||
| ) | ||||
|
|
||||
| @api.depends( | ||||
| "maintenance_ids.close_date", | ||||
| "maintenance_ids.request_date", | ||||
| "maintenance_ids.stage_id.done", | ||||
| "maintenance_ids.maintenance_result", | ||||
| "maintenance_ids.archive", | ||||
| ) | ||||
| def _compute_availability(self): | ||||
| requests = ( | ||||
| self.env["maintenance.request"] | ||||
| .sudo() | ||||
| .search( | ||||
| [ | ||||
| ("equipment_id", "in", self.ids), | ||||
| ("stage_id.done", "=", True), | ||||
| ("maintenance_result", "in", ("passed", "failed")), | ||||
| ("archive", "=", False), | ||||
| ], | ||||
| order="equipment_id, close_date desc, request_date desc, id desc", | ||||
| ) | ||||
| ) | ||||
| latest_by_equipment = {} | ||||
| for request in requests: | ||||
| latest_by_equipment.setdefault(request.equipment_id.id, request) | ||||
| for equipment in self: | ||||
| request = latest_by_equipment.get(equipment.id) | ||||
| equipment.latest_maintenance_result_request_id = request | ||||
| equipment.latest_maintenance_result_date = ( | ||||
| request.close_date or request.request_date if request else False | ||||
| ) | ||||
| if not request: | ||||
| equipment.availability_state = "unknown" | ||||
| elif request.maintenance_result == "passed": | ||||
| equipment.availability_state = "available" | ||||
| else: | ||||
| equipment.availability_state = "unavailable" | ||||
49 changes: 49 additions & 0 deletions
49
maintenance_equipment_availability/models/maintenance_request.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Copyright 2026 Quartile (https://www.quartile.co) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import _, fields, models | ||
|
|
||
|
|
||
| class MaintenanceRequest(models.Model): | ||
| _inherit = "maintenance.request" | ||
|
|
||
| maintenance_result = fields.Selection( | ||
| selection=[ | ||
| ("none", "No Result"), | ||
| ("passed", "Passed"), | ||
| ("failed", "Failed"), | ||
| ], | ||
| default="none", | ||
| copy=False, | ||
| tracking=True, | ||
| ) | ||
| source_request_id = fields.Many2one( | ||
| comodel_name="maintenance.request", | ||
| string="Source Request", | ||
| copy=False, | ||
| readonly=True, | ||
| help="Failed request this follow-up request was created from.", | ||
| ) | ||
| followup_request_ids = fields.One2many( | ||
| comodel_name="maintenance.request", | ||
| inverse_name="source_request_id", | ||
| string="Follow-up Requests", | ||
| ) | ||
|
|
||
| def action_create_followup_request(self): | ||
| self.ensure_one() | ||
| followup = self.env["maintenance.request"].create( | ||
| { | ||
| "name": _("Follow-up of %s", self.name), | ||
| "equipment_id": self.equipment_id.id, | ||
| "maintenance_type": "corrective", | ||
| "source_request_id": self.id, | ||
| } | ||
| ) | ||
| return { | ||
| "type": "ir.actions.act_window", | ||
| "res_model": "maintenance.request", | ||
| "res_id": followup.id, | ||
| "view_mode": "form", | ||
| "target": "current", | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - [Quartile](https://www.quartile.co): | ||
| - Shinnosuke Morita |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| This module adds a pass/fail maintenance result to maintenance requests and | ||
| computes equipment availability from the latest completed maintenance request | ||
| with a result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| When a maintenance request is completed (it reaches a done stage), set its | ||
| Maintenance Result to Passed or Failed. The equipment availability is then | ||
| computed from the latest completed request by completion date. | ||
|
|
||
| - Passed: the equipment is available. | ||
| - Failed: the equipment is unavailable. | ||
| - No result yet: the equipment availability is unknown. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.